fix(redis): Implement ChatMemoryRepository interface and fix test connectivity #2991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbodden
force-pushed
the
redis/pr-rebase-fixes
branch
2 times, most recently
from
1ca8cc6 to
fa30ff5
Compare
…nectivity Refactor Redis-based chat memory implementation to: - Implement ChatMemoryRepository interface as requested in PR spring-projects#2295 - Fix Redis connection issues in integration tests reported in PR spring-projects#2982 - Optimize conversation ID lookup with server-side deduplication - Add configurable result limits to avoid Redis cursor size limitations - Implement robust fallback mechanism for query failures - Enhance support for metadata, toolcalls, and media in messages - Add comprehensive test coverage with reliable Redis connections Signed-off-by: Brian Sam-Bodden <[email protected]>
bsbodden
force-pushed
the
redis/pr-rebase-fixes
branch
from
fa30ff5 to
c894ab9
Compare
|
@markpollack I am almost there with a modularized version of the PR... a few more hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markpollack cc/ @joshlong @ThomasVitale @tzolov with the help of Josh I made some modifications requested for the new changes upstream and the issues with the TestContainers connectivity. I will follow up with an addition to break the functionality into separate modules and do some more clean up. But hopefully this PR will allow you to continue the review. Thanks!
Refactor Redis-based chat memory implementation to:
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits