Skip to content

Conversation

@psilberk
Copy link

Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:

  • Add a Signed-off-by line to each commit (git commit -s) per the DCO
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

For more details, please check the contributor guide.
Thank you upfront!

psilberk and others added 3 commits October 22, 2025 20:19
Signed-off-by: psilberk <[email protected]>
Signed-off-by: Pablo Silberkasten <[email protected]>
@ilayaperumalg
Copy link
Member

Hi @psilberk Thanks for the PR! We already have a PR addressing support for Oracle Dialect to ChatMemory #3601. Could you review the PR#3601 instead of having a duplicate one please?

@psilberk
Copy link
Author

Hi @ilayaperumalg , yes, sorry I didn't see that PR! It looks like several things need to be updated int this other PR, some minors (like the switch instead of multiple if else) and some more complex (tests). It also has an unnecessary index in the schema creation.

@ilayaperumalg
Copy link
Member

@psilberk No problem at all. thanks for your contribution! Could you add your review comments in #3601 and we can discuss the best way forward to get Oracle ChatMemory support added by co-ordinating this with @fanxt0218?

@ericbottard ericbottard changed the title Add Oracle Dialect Add Oracle Dialect for ChatMemory Oct 24, 2025
@ilayaperumalg
Copy link
Member

@psilberk Once you can confirm collaborating with the PR #3601, we can close this PR as duplicate. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants