Skip to content

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Oct 26, 2025

Description

This PR adds critical tests for the OpenAiApi builder and mutation patterns, ensuring proper behavior around object references, configuration preservation, and instance independence.

Changes

Added comprehensive tests for builder and mutation operations:

  • Test builder shared reference behavior with headers
  • Verify ResponseErrorHandler preservation during mutations
  • Validate header independence between original/mutated instances
  • Test NoopApiKey implementation support

Tests

  • Documents builder reference semantics (shared mutable collections)
  • Ensures critical configs survive mutations
  • Validates instance isolation
  • Confirms ApiKey implementation flexibility

…ation

Signed-off-by: Oleksandr Klymenko <[email protected]>

Co-authored-by: Oleksandr Klymenko <[email protected]>
@ilayaperumalg ilayaperumalg added this to the 1.1.0.M4 milestone Oct 28, 2025
@ilayaperumalg ilayaperumalg self-assigned this Oct 28, 2025
@ilayaperumalg
Copy link
Member

@alxkm Thanks for the PR! Rebased and merged as 062e494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants