Prevent ID token refresh in device code flow #2177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
fine-pine
force-pushed
the
gh-2037
branch
2 times, most recently
from
f3eec52 to
7430616
Compare
injae-kim
reviewed
Aug 26, 2025
...ver/authorization/authentication/OAuth2DeviceAuthorizationRequestAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
jgrandja
added
type: bug
jgrandja
requested changes
Sep 19, 2025
There was a problem hiding this comment.
Thanks for the fix @fine-pine. Please see review comments.
Also, there are a couple of failing tests so please run the build and ensure it passes before submitting your changes.
Lastly, please rebase the fix on 1.4.x. Thanks.
...ver/authorization/authentication/OAuth2DeviceAuthorizationRequestAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...ity/oauth2/server/authorization/authentication/OAuth2RefreshTokenAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
- Disallow usage of the `openid` scope in device authorization requests - Allow ID token refresh when an ID token already exists Closes spring-projectsgh-2037 Signed-off-by: fine-pine <[email protected]>
Co-authored-by: injae kim <[email protected]> Signed-off-by: Lee Song Mok <[email protected]>
Signed-off-by: fine-pine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openidscope in device authorization requestsCloses gh-2037