Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify findChild(..) method in BomPlugin #43773

Closed
wants to merge 1 commit into from
Closed

Simplify findChild(..) method in BomPlugin #43773

wants to merge 1 commit into from

Conversation

jxblum
Copy link
Contributor

@jxblum jxblum commented Jan 10, 2025 •
edited by snicoll
Loading

Delegate child Node matching logic to isNodeWithName(..) method.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 10, 2025
jxblum added a commit to jxblum/spring-boot that referenced this pull request Jan 10, 2025
@jxblum
Simplify findChild(..) method in BomPlugin
fcf30d9 
Delegate child Node matching logic to isNodeWithName(..) method.

Closes spring-projects#43773

Signed-off-by: John Blum <[email protected]>
@wilkinsona
Copy link
Member

Thanks for the PR, @jxblum. Can you please align the email address used for the commit and the email address used to sign it off? You can see the details of the mismatch here.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jan 14, 2025
@jxblum
Copy link
Contributor Author

jxblum commented Jan 14, 2025

Hi @wilkinsona- My apologies. Will do.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 14, 2025
@jxblum
Simplify findChild(..) method in BomPlugin
96d0aee 
Delegate child Node matching logic to isNodeWithName(..) method.

Closes spring-projects#43773

Signed-off-by: John Blum <[email protected]>
@jxblum
Copy link
Contributor Author

jxblum commented Jan 14, 2025

Fixed :)

@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Jan 15, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Jan 15, 2025
@mhalbritter mhalbritter self-assigned this Jan 15, 2025
@mhalbritter mhalbritter mentioned this pull request Jan 15, 2025
Closed
mhalbritter pushed a commit that referenced this pull request Jan 15, 2025
@jxblum @mhalbritter
Simplify findChild method in BomPlugin
ebffe6a 
See gh-43773

Signed-off-by: John Blum <[email protected]>
@mhalbritter
Copy link
Contributor

mhalbritter commented Jan 15, 2025 •
edited
Loading

Thanks @jxblum and great to see you in the tracker ❤️ !

@mhalbritter mhalbritter modified the milestones: 3.3.x, 3.3.8 Jan 15, 2025
@jxblum
Copy link
Contributor Author

jxblum commented Jan 15, 2025

Thank you @mhalbritter. Be well my friend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: task A general task
Projects
None yet
Milestone
3.3.8
Development

Successfully merging this pull request may close these issues.
4 participants
@jxblum @wilkinsona @mhalbritter @spring-projects-issues