Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the comma in "spring.config.activate.on-profile" value and add test #44866

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Mar 25, 2025

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 25, 2025
@wilkinsona
Copy link
Member

Thanks for the suggestion but I think this may cause confusion. , isn't really the equivalent of |. It's a separator for the expressions when configured as a single comma-separate value due to it being bound to a String[]. If it's configured as a list, no separation occurs. In other words, the following two snippets of YAML are not equivalent:

spring.config.activate.on-profile:
    - a|b
spring.config.activate.on-profile:
    - a,b

I think it would be better to update the table in this section of the documentation to describe on-profile more accurately. Perhaps something like "profile expressions of which at least one must match for the document to be active".

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Mar 25, 2025
@quaff
Copy link
Contributor Author

quaff commented Mar 26, 2025

Updated, could someone review the wording?

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants