Skip to content

Make type in ProblemDetail nullable #35294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+5 −8
Closed

Make type in ProblemDetail nullable #35294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91f2c25
Make `type` in `ProblemDetail` nullable
cw-dimedis Aug 6, 2025
f725ea9
Remove default type of "about:blank" in `ProblemDetail`
cw-dimedis Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions spring-web/src/main/java/org/springframework/http/ProblemDetail.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,8 @@ public class ProblemDetail implements Serializable {

private static final long serialVersionUID = 3307761915842206538L;

private static final URI BLANK_TYPE = URI.create("about:blank");


private URI type = BLANK_TYPE;
private @Nullable URI type;

private @Nullable String title;

Expand Down Expand Up @@ -104,18 +102,17 @@ protected ProblemDetail() {

/**
* Setter for the {@link #getType() problem type}.
* <p>By default, this is {@link #BLANK_TYPE}.
* <p>By default, this is not set. According to the spec, when not present, its value is assumed to be "about:blank"
* @param type the problem type
*/
public void setType(URI type) {
Assert.notNull(type, "'type' is required");
public void setType(@Nullable URI type) {
this.type = type;
}

/**
* Return the configured {@link #setType(URI) problem type}.
*/
public URI getType() {
public @Nullable URI getType() {
return this.type;
}

Expand Down Expand Up @@ -245,7 +242,7 @@ public void setProperties(@Nullable Map<String, Object> properties) {
@Override
public boolean equals(@Nullable Object other) {
return (this == other || (other instanceof ProblemDetail that &&
getType().equals(that.getType()) &&
ObjectUtils.nullSafeEquals(getType(), that.getType()) &&
ObjectUtils.nullSafeEquals(getTitle(), that.getTitle()) &&
this.status == that.status &&
ObjectUtils.nullSafeEquals(this.detail, that.detail) &&
Expand Down