-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Allow multiple ServerLogoutHandler instances in WebFlux #17381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
blake-bauman
wants to merge
1
commit into
spring-projects:main
Choose a base branch
from
blake-bauman:multi-logout-handler-webflux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3022,14 +3022,15 @@ public final class LogoutSpec { | |
|
||
private final SecurityContextServerLogoutHandler DEFAULT_LOGOUT_HANDLER = new SecurityContextServerLogoutHandler(); | ||
|
||
private List<ServerLogoutHandler> logoutHandlers = new ArrayList<>(Arrays.asList(this.DEFAULT_LOGOUT_HANDLER)); | ||
private List<ServerLogoutHandler> logoutHandlers = new ArrayList<>(); | ||
|
||
private LogoutSpec() { | ||
} | ||
|
||
/** | ||
* Configures the logout handler. Default is | ||
* {@code SecurityContextServerLogoutHandler} | ||
* {@code SecurityContextServerLogoutHandler}. This clears any previous handlers | ||
* configured. | ||
* @param logoutHandler | ||
* @return the {@link LogoutSpec} to configure | ||
*/ | ||
|
@@ -3039,7 +3040,12 @@ public LogoutSpec logoutHandler(ServerLogoutHandler logoutHandler) { | |
return addLogoutHandler(logoutHandler); | ||
} | ||
|
||
private LogoutSpec addLogoutHandler(ServerLogoutHandler logoutHandler) { | ||
/** | ||
* Adds a logout handler in the last position. | ||
* @param logoutHandler | ||
* @return the {@link LogoutSpec} to configure | ||
*/ | ||
public LogoutSpec addLogoutHandler(ServerLogoutHandler logoutHandler) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of exposing |
||
Assert.notNull(logoutHandler, "logoutHandler cannot be null"); | ||
this.logoutHandlers.add(logoutHandler); | ||
return this; | ||
|
@@ -3088,7 +3094,7 @@ private ServerLogoutHandler createLogoutHandler() { | |
this.DEFAULT_LOGOUT_HANDLER.setSecurityContextRepository(securityContextRepository); | ||
} | ||
if (this.logoutHandlers.isEmpty()) { | ||
return null; | ||
return DEFAULT_LOGOUT_HANDLER; | ||
} | ||
if (this.logoutHandlers.size() == 1) { | ||
return this.logoutHandlers.get(0); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you please add
@since 7.0