Propagate Authorities From Previous Factors #17790
Open
+1,445
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
changed the title
jzheaux
force-pushed
the
authentication-builder
branch
6 times, most recently
from
6eb00d0 to
b48b10a
Compare
rwinch
requested changes
Aug 27, 2025
There was a problem hiding this comment.
Thanks for the PR @jzheaux! I've provided feedback inline, but my main pieces of feedback are:
- The
AuthenticationManagershould not be accessing theSecurityContext. Instead, we should have the controller (e.g.Filter) that invokes theAuthenticationManagerperform the merging of the twoAuthenticationinstances. - I think that the builder APIs should function independently of MFA and should work for any properties on the
Authentication. Doing this would also allow deprecation of thesetAuthenticatedmethod. - I don't think we should have an
Authentication.apply(Authentication)method. Especially so if it is only applying the authorities and ignoring many other properties that are on theAuthenticationobject.
core/src/main/java/org/springframework/security/authentication/AbstractAuthenticationToken.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/authentication/AbstractAuthenticationToken.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/authentication/AbstractAuthenticationToken.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/authentication/AbstractAuthenticationToken.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/authentication/AbstractAuthenticationToken.java
Outdated
Show resolved
Hide resolved
cas/src/main/java/org/springframework/security/cas/authentication/CasAuthenticationToken.java
Outdated
Show resolved
Hide resolved
cas/src/main/java/org/springframework/security/cas/authentication/CasAuthenticationToken.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/security/authentication/DelegatingReactiveAuthenticationManager.java
Outdated
Show resolved
Hide resolved
| @@ -54,6 +57,9 @@ | |||
| */ | |||
| public interface Authentication extends Principal, Serializable { | |||
|
|
|||
| @Serial | |||
| long serialVersionUID = -3884394378624019849L; | |||
There was a problem hiding this comment.
Can you help me to understand why this is specified?
There was a problem hiding this comment.
Deserialization of concrete implementations fails otherwise. With the inclusion of a default method, Java now treats it like an abstract class from a serialization perspective. From what I understand, any class, abstract or otherwise, should have a version id if it extends Serializable.
...ngframework/security/saml2/provider/service/authentication/Saml2AssertionAuthentication.java
Outdated
Show resolved
Hide resolved
jzheaux
force-pushed
the
authentication-builder
branch
from
b48b10a to
41398f0
Compare
The sample better matches a value that would be used in the constructor Issue spring-projectsgh-16276
Given that 7e3bf96 changes the InteractiveAuthenticationSuccessEvent serialization sample, this commit syncs up the 6.5.x version to match. Issue spring-projectsgh-16276
Given that 7e3bf96 changes the InteractiveAuthenticationSuccessEvent serialization sample, this commit syncs up the 7.0.x version to match. Closes spring-projectsgh-16276
This commit adds a new default method to Authentication for the purposes of creating a Builder based on the current authentication, allowing other authentications to be applied to it as a composite. It also adds Builders for each one of the authentication result classes.
This commit allows looking up the current authentication and applying it to the latest authentication. This is specifically handy when collecting authorities gained from each authentication factor.
This commit provides the SecurityContextHolderStrategy bean to ProviderManager instances that the HttpSecurity DSL constructs.
- Added remaining properties - Removed apply method since Spring Security isn't using it right now - Made builders extensible since the authentications are extensible
jzheaux
force-pushed
the
authentication-builder
branch
from
31634e2 to
5e94df2
Compare
jzheaux
force-pushed
the
authentication-builder
branch
from
5e94df2 to
4d89979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications can use
AuthenticationBuilderto apply existing authentications to new ones.For example, if the current logged in user is represented by:
And they provide a second set of authenticated credentials, represented by:
Then the first factor can be applied to the second factor as follows:
This draft PR adds a basic builder to each Authentication implementation that implements
Authentication.Builder. In order to simplify upgrades,toBuilderby default returns a no-op implementation ofAuthentication.Builderthat ultimately returns the same authentication unchanged.