typ values should not be case-sensitive in JwtTypeValidator
#18101
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
type: bug
Contributor
|
It's important that we make sure we are following specs as well as providing a reasonable migration path. Checking the JWS RFC, it states (emphasis mine):
So I agree that this is a bug and can be fixed in time for the 7.0 release. Thanks for spotting it, @namest504! |
Closes spring-projectsgh-18092 Signed-off-by: namest504 <[email protected]>
jzheaux
force-pushed
the
namest504/fix-case-in-JwtTypeValidator
branch
from
1230e77 to
e06dd94
Compare
jzheaux
changed the title
typ values should not be case-sensitive in JwtTypeValidator
Contributor
|
Thanks, @namest504! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #18092
The JwtTypeValidator was performing a case-sensitive check for the JWT typ header, which was a change from the behavior of the previous Nimbus JOSEObjectTypeVerifier.
This commit updates the JwtTypeValidator to be case-insensitive.
New test cases have been added to verify this change.