add lint warning for cf stack cflinuxfs3

linters/cf_manifest.go

@@ -38,6 +38,10 @@ func LintCfManifest(task manifest.DeployCF, readCfManifest cf.ManifestReader) (e
 		errs = append(errs, ErrCFMissingName.WithFile(task.Manifest))
 	}
 
+	if app.Stack == "cflinuxfs3" {
+		errs = append(errs, ErrCFStack.WithFile(task.Manifest))
+	}
+
 	errs = append(errs, lintRoutes(task, app)...)
 	errs = append(errs, lintCandidateAppRoute(task, cfManifest)...)
 	errs = append(errs, lintDockerPush(task, app)...)

linters/cf_manifest_test.go

@@ -312,4 +312,13 @@ applications:
 		assertNotContainsError(t, errs, ErrCFLabelProductIsMissing)
 		assertNotContainsError(t, errs, ErrCFLabelEnvironmentIsMissing)
 	})
+
+	t.Run("Warning for stack cflinuxfs3", func(t *testing.T) {
+		cfManifest := `
+applications:
+- stack: cflinuxfs3
+`
+		errs := LintCfManifest(manifest.DeployCF{Space: "Yo"}, cfManifestReader(cfManifest, nil))
+		assertContainsError(t, errs, ErrCFStack)
+	})
 }

linters/errors.go

@@ -39,6 +39,7 @@ var (
 
 	ErrCFLabelTeamWillBeOverwritten = newError("deployment will overwrite metadata.labels.team that was set in the CF manifest").AsWarning()
 	ErrCFLabelProductIsMissing      = newError("CF manifest is missing 'product' label. If 'product' is set on the CF space you can safely ignore this warning.").AsWarning()
+	ErrCFStack                      = newError("CF stack 'cflinuxfs3' is deprecated. Please upgrade to 'cflinuxfs4'.").AsWarning()
 	ErrCFLabelEnvironmentIsMissing  = newError("CF manifest is missing 'environment' label. If 'environment' is set on the CF space you can safely ignore this warning.").AsWarning()
 
 	ErrUnsupportedRegistry = newError("image must be from halfpipe registry. Please see <https://ee.public.springernature.app/rel-eng/docker-registry/>")