Repository navigation
docs(debug-journal): fold the 2026-10-25..28 queue slice (14 of 15 candidates); correct #5281/#5699/#5643/#5640 entries - #5830
Draft
springfall2008 wants to merge 1 commit into
Draft
springfall2008 wants to merge 1 commit into
springfall2008 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated journal flush — /journal-update, 2026-10-29. Every claim below was re-verified against
origin/main83a4adadbefore it went in; this PR is the review gate.Folds in 14 of the first 15 queued candidates (slice
4186→5765, filename order); 1 dropped. 43 candidates remain queued (from5766onward) for the next slices.Folded in
git rev-parse HEAD == headRefOidproves nothing, check the tip commit's message for a(#M)suffix with M ≠ N, and a squash on a PR head branch exists only onrefs/pull/<n>/head. The merge-base staleness part was already the adjacent bullet, so it is referenced, not repeated.plugin_system.py)" row in the per-integration notes, re-verified on main:load_plugin()'s name-sortedgetmembers()first match lets the imported basePredBatPluginwin (Initialising plugin class (name-based)), the_plugin.pysingle-level scan, the probe trap (a class sorting before the base passes with and without the fix), and — marked open-at-writing — PR fix(plugins): discovery must not instantiate an imported base class #4319's__module__guards with the two review-flagged consequences (re-export break, strategy-2 double-init).gateway_evc_control's stateless reconcile (SetChargingProfile + RemoteStart in-window, RemoteStop out-of-window,_EV_COMMAND_ATTEMPTS3 /_EV_COMMAND_RETRY_SECONDS120s, only_ev_control_cp_iddriven, read-only double-check) — all symbols re-grepped on main.predbat.control_failures(publish_control_failures(), predbat.py) and its event schema (epochslot_start/slot_end, requested/measured watts) with the "check it first + counts are the chronicity tell" guidance; (b) the Teslemetry row's GH#5748 passage adds that the plan-displayHoldChrgthere is the predicted fill-then-hold, not what was executed; (c) the replay section gains the third loader-crash cause — a dump whose capturedargscarry!secrettags (no constructor registered) and the sed-to-dummy workaround. The row's existing signal-tariff material was left alone, and the replay!secretrow explicitly distinguishes itself from the apps.yaml boot-parsing!secretrow.astimezone(self.local_tz)fix shape, "a fresh decode after the change self-corrects" as the discriminator between re-rendering and re-deriving, the change-night execute test gap, and the persistence route kept explicitly suspected (it stayed marked that way, not upgraded).events/joinedEventson the saving-session query flows throughget_saving_session_data()unguarded (.get("events", [])→None→ TypeError) — kept explicitly "unverified whether Octopus actually nulls these two"; re-verified the still-live code shape on main 2026-10-29. Dropped the candidate's Kraken provider-deprecation bullet: already fixed on main (f7358455, GH#5754, 2026-10-25) — nothing for an older-log reader, so it came out.binary_sensor.predbat_running) — new trap bullet ("Docs entity names that live in HA core, not this repo"): the hassio Supervisor per-add-on Running sensor, disabled by default, absent on Container/Core, docs/install.md tells users to enable it while the Error Monitor section doesn't, and the general "don't grep apps/predbat for docs entity names" rule. Verified against main's docs and the PR/issue's HA-core source read.statisticsTime) — folded into the Sigenergy row as merged content (ef1432b, 2026-10-25; then fix(sigenergy): widen MQTT freshness window to 450s so cadence jitter doesn't trigger REST polls #5790 widened the arrival window whileSIGENERGY_MQTT_STALE_SECONDSstays 300 — verified): the lag gate in_mqtt_listener_loop(), the merge-onto-mqtt_period_rawinvariant, and the do-not-reorder trap (last_mqtt_updatestays arrival-based because it isinverter_timeand freezes turn laggy-but-healthy feeds into clock-skew restarts).include.entities-alone default-deny case the candidate's framing misses).gh apiflag order before-vs-after the endpoint decides permission (flags after), issue events oldest-first (tail = latest), exact-phrase PR search understates vs bare-token (search#<n> in:bodytoo), and aBOT_PRevent can be authored by the bot's own credential. feat(triage-daemon): label bot PRs and assign them to whoever added BOT_PR #5759 itself merged (7e42019).minutes_back = minutes_now + 1lookup family incalculate_yesterday()(cost_yesterday, carbon_yesterday, the History arrays, cost_yesterday_car, yesterday_adjustment_pct) reads the wrong day's value on a change day — cross-referenced against the rate_replicate variant in the row above; totals self-correct; and the do-not-fix-minutes_nowtrap with both probe traps (localize the wall midnight; nothing covers a change day).dynamic_load()'s car subtraction readsin_car_slot()overcar_charging_slotsrebuilt from the trimmed dispatches, so the trimmed start covers 1–2 of the 5 lookback minutes and the ended-dispatch drop leaves nothing subtracted (Dynamic load adjust is setting load minimumis the symptom line, bounded impact, test gap recorded, Octopus API: the trimmed tail of a long running dispatch is treated as a short dispatch (#5657) #5702/IOG Car charging energy not being recognised in history and being added to house load. #5602 cross-referenced as sibling mechanisms).batteryNum == 0/batteryJump.batteryCount == 0corroborators (an omission the candidate proved against_reports_no_battery()'s docstring and code on main), plus the'0'/'0.0'alternate-poll instability and PR fix(solis): stop enrolling a grid-tied string inverter as a battery inverter #5764'sSOLIS_GRID_TIED_MACHINE_PATTERN(merged 9985960, 2026-10-26) with its no-pack-count-corroboration rule and themachinefield's log visibility.{device_id}hook placeholder (verifiedget_arg("device_id", index=self.id, default="")on main) and the window-entry worst case of the{power}trail (immediate calls run inside the per-inverter loop before theapply_rate_intent()rate writes → first dispatch runs at the idle max, ~0.8 kWh off-plan at 10 kW, not template-fixable).Dropped
verify:service sequences) — everything it pins is PR-branch-only (call_service_sequence/prepare_service_sequenceare absent from main, verified by grep) and PR Add shared Deye/Solarman template with observed service sequences #5505 is unmerged; the one durable generalisation it carried (a custominverter_typeneeds no code change — GE-def synthesis) is already in the review-conventions trap bullet. Its remaining content is forward-looking PR narrative that goes stale like PR-branch text has twice before ("unmerged at writing" Gateway items), so it stays out until the PR lands.Existing entries corrected (re-check against merges since 2026-10-15)
SIGENERGY_MQTT_STALE_SECONDSis still 300 on main).Branch
bot/debug-journal-2026-10-29.