Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix didkit paths in CI #112

Closed
wants to merge 1 commit into from
Closed

Fix didkit paths in CI #112

wants to merge 1 commit into from

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Mar 18, 2021

Fix #111 caching of Rust build artifacts in CI.

Full run, no cache: https://github.com/spruceid/didkit/runs/2142681378 45m 49s
Subsequent run, with caching: https://github.com/spruceid/didkit/runs/2143040544: failed for disk space reasons. Looks like we have to free up more space to make room for the larger cache file.

Cache size which previously was ~263 MB (probably containing just the cargo registry data); is now up to ~2141 MB (step:4:23).

Base automatically changed from fix/use-runner-android-sdk to main March 18, 2021 18:57
@wyc
Copy link
Contributor

wyc commented Jul 22, 2021

Hi @clehner, is this ready for review?

@clehner
Copy link
Contributor Author

clehner commented Jul 22, 2021

@wyc I'm not sure how to proceed here. I believe the change does what it is supposed to do, enabling caching the build artifacts (target/), however it was causing test failure due to running out of space because of the size of the data to cache. I experimented with deleting existing files from the CI environment, to free up space (in order to hold the cache data), in #109, but that added more time to the run to delete all those files. I recall that the time deleting the files to free up space was close to or greater than the time saved by caching the build artifacts, so I stopped pursuing it after other changes (#110, #116) stopped the out-of-space issue (#108) that we were seeing around that time. The CI run here currently takes an hour, so reducing that could be good; I could look into these changes and #109 again if that would be useful; otherwise I think this PR could be closed or changed to simply remove the incorrectly-referenced paths.

@bumblefudge
Copy link
Contributor

@clehner will open an issue for tracking purposes

@bumblefudge bumblefudge closed this Sep 7, 2021
@clehner clehner mentioned this pull request Sep 7, 2021
@sbihel sbihel deleted the fix/cargo-cache branch October 24, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo build artifacts not cached
3 participants