Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add did:webkey and sign with ssh-agent functionality #158

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Add did:webkey and sign with ssh-agent functionality #158

merged 3 commits into from
Jul 6, 2021

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Apr 29, 2021 •
edited
Loading

Close #154

Depends on: spruceid/ssi#178

  • Get socket path
  • Connect to socket
  • List keys in agent
  • Pick key in agent to use
  • Request signature from agent
  • Apply signature to proof
  • Reuse mechanism for all issue/sign commands
  • Consider changes in ssi
  • Document feature in README(s)
  • Make error messages helpful
  • Tests (partial)

Future work

@clehner clehner force-pushed the feat/ssh-agent-signing branch 2 times, most recently from 20f4b46 to dcf81b2 Compare May 20, 2021 00:44
@clehner clehner changed the title WIP: add sign with ssh-agent option Add did:webkey and sign with ssh-agent functionality May 20, 2021
@clehner clehner marked this pull request as ready for review May 20, 2021 01:20
@clehner clehner marked this pull request as draft May 24, 2021 13:09
@clehner clehner marked this pull request as ready for review May 24, 2021 13:09
@clehner clehner mentioned this pull request May 27, 2021
Merged
19 tasks
sbihel
sbihel approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

cli/src/ssh_agent.rs Outdated
pub key_type: String,
}

async fn read_msg(ssh_agent_sock: &mut tokio::net::UnixStream) -> Result<Message, ReadError> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe those functions could be methods but not sure it would make things clearer, it's already pretty concise.

@clehner clehner marked this pull request as draft June 25, 2021 13:40
@clehner clehner marked this pull request as ready for review July 2, 2021 20:45
This was referenced Jul 6, 2021
Open
Open
Open
@clehner
Copy link
Contributor Author

clehner commented Jul 6, 2021

This PR is ready for review (again). Merge conflicts with #166 have been fixed. SSH Agent functionality is moved from didkit-cli into didkit (lib/), so it could could be used with didkit-http. Actual didkit-http integration will be tracked by #174. JWT ssh-agent signing in didkit-cli will throw an error currently; fixing this will be tracked by #173, and will require changes to ssi (spruceid/ssi#221).

@clehner
Copy link
Contributor Author

clehner commented Jul 6, 2021

Rebasing for merging...

@clehner clehner force-pushed the feat/ssh-agent-signing branch from 228042a to 96dcbb5 Compare July 6, 2021 17:12
@clehner clehner merged commit 96dcbb5 into main Jul 6, 2021
@clehner clehner deleted the feat/ssh-agent-signing branch July 6, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbihel sbihel sbihel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSH Agent for signing
2 participants
@clehner @sbihel