Skip to content

Remove redundant check for outputkind target compatibility #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antocuni merged 1 commit into from
Aug 10, 2026
Merged

Remove redundant check for outputkind target compatibility #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions spy/build/ninja.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import py.path

from spy.build.config import BuildConfig, CompilerConfig
from spy.errors import WIP
from spy.textbuilder import TextBuilder
from spy.util import robust_run

Expand Down Expand Up @@ -37,12 +36,6 @@ class NinjaWriter:
out: Optional[str]

def __init__(self, config: BuildConfig, build_dir: py.path.local) -> None:
# for now, we support only some combinations of target/kind
if config.kind == "testlib":
if config.target not in ("wasi", "emscripten"):
raise WIP(
"--output-kind=testlib works only for wasi and emscripten targets"
)
self.config = config
self.build_dir = build_dir
self.out = None
Expand Down
Loading