Exception reporter disentangling for Android UI code #1345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
approved these changes
Jun 17, 2025
| @@ -3,6 +3,33 @@ package com.squareup.workflow1.internal | |||
| import kotlin.contracts.ExperimentalContracts | |||
| import kotlin.contracts.contract | |||
|
|
|||
| /** | |||
| * Like Kotlin's [requireNotNull], but uses [stackTraceKey] to create a fake top element | |||
| * on the stack trace, ensuring that BugSnag's default grouping will create unique | |||
There was a problem hiding this comment.
nit: You could generalize this to "any crash reporter that uses stacktrace" rather than particular Bugsnag.
There was a problem hiding this comment.
Thanks, accidental copy paste from the internal method.
| * @throws IllegalArgumentException if the [value] is false. | ||
| */ | ||
| @OptIn(ExperimentalContracts::class) | ||
| inline fun <T : Any> requireNotNullWithKey( |
There was a problem hiding this comment.
i think you'll have to mark this public for explicit API mode, right?
There was a problem hiding this comment.
Yup. I wonder why the build didn't catch that?
There was a problem hiding this comment.
Oooh, I wonder if we turned off that check for internal package. If so I think I can undo the other explicit publics I added in here. Trying it out…
rjrjr
force-pushed
the
ray/more-exception-detangling
branch
from
6ab9934 to
2e1add9
Compare
Uses `Throwable.withKey` in a few more choke points, to break up crash reporter kitchen sinks. Had to make a few `internal` core methods public to allow their use from the android modules, but I think that's okay -- they're still in a package named `internal`, our intent should be clear.
rjrjr
force-pushed
the
ray/more-exception-detangling
branch
from
2e1add9 to
0495048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
Throwable.withKeyin a few more choke points, to break up crash reporter kitchen sinks. Had to make a fewinternalcore methods public to allow their use from the android modules, but I think that's okay -- they're still in a package namedinternal, our intent should be clear.