Skip to content

[ci] do not suspend scheduled bundle job after inactivity of repository #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: squeak-trunk
Choose a base branch
from

Conversation

LinqLover
Copy link
Contributor

@tonyg
Copy link
Member

tonyg commented Aug 16, 2025

I like it! Can (and/or should) we vendor the dependency on the reactivation workflow step?

@LinqLover
Copy link
Contributor Author

To vendor = fork the actions repository (liskin/gh-workflow-keepalive)? :-) Sure, we could. Not sure how much value that adds, though. We would be cut off from updates (fixes) to the action and after all, we depend on implementation details of the GitHub Actions infrastructure for this optional feature anyway. I'm more on the side of trunk-based development/EAFP/fix it when it breaks. :-)

Best,
Christoph

@tonyg
Copy link
Member

tonyg commented Aug 18, 2025

Yes, fork it or include the essential portion of it directly in our CI script. CI actions are, generally speaking, not great from a security perspective, so it'd be nice to just do what we need minimally ourselves rather than pull in privileged code under control of someone else. That said, it's extra work, so I completely understand if it's not something to be done Right Now :-)

@marceltaeumel
Copy link
Member

Does the "write" permission in this action means that it has also potential access to this repository's secrets can can thus extract the private certificates (*.enc files) without our knowledge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants