Expand Echo Search #714
Merged
Expand Echo Search #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarkah
reviewed
Jan 24, 2025
Comment on lines
-158
to
+159
| Received, | ||
| /// is_echo | ||
| Received(bool), |
There was a problem hiding this comment.
@andymandias This breaks history. All my messages got deleted :(
We need to make sure we add things in a backwards compatible way
This means we need a custom De-serialize implementation for Direction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the search time interval when inserting an echo (message sent by the user received from the server) into message history. This is to help address the duplicate messages issue discussed in #709.