Feat/refresh sh to dart exec #227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to dart executable
…tzf and dart data files
…n the tool/refresh.dart script
…nd if the underlying utilities are not present
…ion with UTC by default
Replaced late-initialized fields with final fields initialized via a factory and private constructor.
…ions and overwrites
…tFile to avoid "dartimplementation_imports" lint error when consumed directly in other package Import of a library in the 'lib/src' directory of another package. Try importing a public library that exports this library, or removing the import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a dart executable tool from the existing tool/refresh.sh, to create the timezone files right in the package without cloning this repository.
Usage:
dart run timezone:refreshFixes Field '_local' has not been initialized. #226 . Also, removed late initialization from
_cacheZonefield inside the Location class, and initialized it via factory constructor.All tests pass.
@srawlins Please review, and lmk if anything is wrong/not up to standard.