feat(core): Translations support, entities management, cleanup code#22
Merged
Rushaway merged 2 commits intosrcdslab:masterfrom Mar 21, 2026
Merged
feat(core): Translations support, entities management, cleanup code#22Rushaway merged 2 commits intosrcdslab:masterfrom
Rushaway merged 2 commits intosrcdslab:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds translation support and improves runtime safety/cleanup for the Shop_ZRSkins SourceMod plugin, aligning chat output and preview handling with more robust entity/timer management.
Changes:
- Introduces a new translations file and loads it at plugin startup for localized chat messages.
- Refactors preview/timer logic to use userids +
TIMER_FLAG_NO_MAPCHANGE, adds client validation, and adds an edicts-limit guard before spawning preview entities. - Updates CI packaging to include the
addons/sourcemod/translationsdirectory in build artifacts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| addons/sourcemod/translations/Shop_ZRSkins.phrases.txt | Adds localized phrases used by the plugin’s chat output. |
| addons/sourcemod/scripting/Shop_ZRSkins.sp | Loads translations, refactors skin/preview logic, adds validation and entity-limit checks, and cleans up code paths. |
| .github/workflows/ci.yml | Copies translations into the packaged artifact so servers receive the new phrases file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.