Conversation
Added error logging for model precaching failures.
There was a problem hiding this comment.
Pull request overview
This PR improves robustness of the Shop_ZRSkins SourceMod plugin by adding checks and logging around model precaching so invalid/missing models don’t get registered or applied.
Changes:
- Bumped plugin version to 1.2.1.
- Added a post-
PrecacheModelverification (IsModelPrecached) withLogErrorand skipping of invalid items. - Prevented
SetEntityModelcalls unless the requested model is already precached.
Ensure KeyValues object is deleted after use to prevent memory leaks.
Added error handling for empty skin paths and improved model precaching logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added error logging for model precaching failures.