Sync with upstream and Rails 8 changes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
This is mostly useful for matchers like have_received that have to be
called after the action and are not called on the subject. So, e.g.:
it { should satisfy { expect(foo).to have_received(:wibble) } }
vs.
it "calls the method" do
subject.call
expect(foo).to have_received(:wibble)
end
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Version 2.2.0 changes the module to be included. Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Authored-by: Adam Milligan <[email protected]>
Version 1.47 of rubocop has changes to the Lint/MissingSuper cop. The new behavior no longer finds an error with the super-less initializer.
This reverts commit 96e86b9.
- Updated ActiveStorage::Service::Configurator to use proper Rails 8 approach - Removed explicit Rails version constraint for better compatibility - Updated dependencies to latest versions - Added new matchers and helpers from upstream
- Convert double quotes to single quotes where appropriate - Fix indentation and layout issues - Use Hash#key? instead of Hash#has_key? - Fix module/class nesting style - Remove trailing empty lines
- Add supports_block_expectations to send_rollbar_report matcher
- Fixes 'You must pass an argument rather than a block to expect' error
- Allows matcher to work with expect { ... }.to syntax in Rails 8
- Store index calls under :index key instead of :create key - Fixes tests expecting Doubles::Elasticsearch::Client.calls[:index] to work - This was causing nil values when tests expected arrays
…rnings" This reverts commit ccf59cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.