Bump ssb-backlinks #1251

arj03 · 2020-02-20T15:56:01Z

This should be much faster especially for onboarding people. See this issue for details.

christianbundy · 2020-02-21T21:37:20Z

Thanks! I'm excited to merge this, do you mind if I leave it open for a couple days just to make sure we fix #1253 before adding indexing to the mix?

arj03 · 2020-02-21T21:55:54Z

No please. No rush

Powersource

Tried this now and stuff works for me. I don't know exactly what the index is used for though so I might miss something. And gonna let Christian click merge on this (idk the release schedule or whatever you wanna call it :p ).

Powersource

.

Powersource · 2020-02-24T19:04:59Z

Got infinite scuttling. Idk if it's related to this PR or conn-stuff but anyway. A lot of logging, I'll post what I can.

Exception thrown by PacketStream substream end handler Error {}
Error: unexpected hangup
    at Object.cb (/home/me/prj/ssb/patchwork/node_modules/pull-box-stream/index.js:117:44)
    at drain (/home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:46:23)
    at /home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:63:18
    at /home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:114:13
    at drain (/home/me/prj/ssb/patchwork/node_modules/stream-to-pull-stream/index.js:126:18)
    at Socket.<anonymous> (/home/me/prj/ssb/patchwork/node_modules/stream-to-pull-stream/index.js:143:5)
    at Socket.emit (events.js:205:15)
    at endReadableNT (_stream_readable.js:1154:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:9)
Exception thrown by PacketStream substream end handler Error {}
Error: unexpected hangup
    at Object.cb (/home/me/prj/ssb/patchwork/node_modules/pull-box-stream/index.js:117:44)
    at drain (/home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:46:23)
    at /home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:63:18
    at /home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:114:13
    at drain (/home/me/prj/ssb/patchwork/node_modules/stream-to-pull-stream/index.js:126:18)
    at Socket.<anonymous> (/home/me/prj/ssb/patchwork/node_modules/stream-to-pull-stream/index.js:143:5)
    at Socket.emit (events.js:205:15)
    at endReadableNT (_stream_readable.js:1154:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:9)
Exception thrown by PacketStream substream end handler Error {}
Error: unexpected end of parent stream
    at PacketStream.destroy (/home/me/prj/ssb/patchwork/node_modules/packet-stream/index.js:71:7)
    at PacketStream.write (/home/me/prj/ssb/patchwork/node_modules/packet-stream/index.js:133:41)
    at /home/me/prj/ssb/patchwork/node_modules/muxrpc/pull-weird.js:58:44
    at /home/me/prj/ssb/patchwork/node_modules/pull-stream/sinks/drain.js:20:24
    at /home/me/prj/ssb/patchwork/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
    at /home/me/prj/ssb/patchwork/node_modules/packet-stream-codec/index.js:95:24
    at next (/home/me/prj/ssb/patchwork/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:14:9)
    at /home/me/prj/ssb/patchwork/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:16:41
    at Object.cb (/home/me/prj/ssb/patchwork/node_modules/packet-stream-codec/index.js:102:18)
    at drain (/home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:39:14)
Exception thrown by PacketStream substream end handler Error {}
Error: unexpected hangup
    at Object.cb (/home/me/prj/ssb/patchwork/node_modules/pull-box-stream/index.js:117:44)
    at drain (/home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:46:23)
    at /home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:63:18
    at /home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:114:13
    at drain (/home/me/prj/ssb/patchwork/node_modules/stream-to-pull-stream/index.js:126:18)
    at Socket.<anonymous> (/home/me/prj/ssb/patchwork/node_modules/stream-to-pull-stream/index.js:143:5)
    at Socket.emit (events.js:205:15)
    at endReadableNT (_stream_readable.js:1154:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:9)
Exception thrown by PacketStream substream end handler Error {}
Error: unexpected end of parent stream
    at PacketStream.destroy (/home/me/prj/ssb/patchwork/node_modules/packet-stream/index.js:71:7)
    at PacketStream.write (/home/me/prj/ssb/patchwork/node_modules/packet-stream/index.js:133:41)
    at /home/me/prj/ssb/patchwork/node_modules/muxrpc/pull-weird.js:58:44
    at /home/me/prj/ssb/patchwork/node_modules/pull-stream/sinks/drain.js:20:24
    at /home/me/prj/ssb/patchwork/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
    at /home/me/prj/ssb/patchwork/node_modules/packet-stream-codec/index.js:95:24
    at next (/home/me/prj/ssb/patchwork/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:14:9)
    at next (/home/me/prj/ssb/patchwork/node_modules/pull-stream/sinks/drain.js:16:11)
    at /home/me/prj/ssb/patchwork/node_modules/pull-stream/sinks/drain.js:29:15
    at /home/me/prj/ssb/patchwork/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
Exception thrown by PacketStream substream end handler Error {}
Error: unexpected hangup
    at Object.cb (/home/me/prj/ssb/patchwork/node_modules/pull-box-stream/index.js:117:44)
    at drain (/home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:46:23)
    at /home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:63:18
    at /home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:114:13
    at drain (/home/me/prj/ssb/patchwork/node_modules/stream-to-pull-stream/index.js:126:18)
    at Socket.<anonymous> (/home/me/prj/ssb/patchwork/node_modules/stream-to-pull-stream/index.js:143:5)
    at Socket.emit (events.js:205:15)
    at endReadableNT (_stream_readable.js:1154:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:9)
Exception thrown by PacketStream substream end handler Error {}
Error: unexpected end of parent stream
    at PacketStream.destroy (/home/me/prj/ssb/patchwork/node_modules/packet-stream/index.js:71:7)
    at PacketStream.write (/home/me/prj/ssb/patchwork/node_modules/packet-stream/index.js:133:41)
    at /home/me/prj/ssb/patchwork/node_modules/muxrpc/pull-weird.js:58:44
    at /home/me/prj/ssb/patchwork/node_modules/pull-stream/sinks/drain.js:20:24
    at /home/me/prj/ssb/patchwork/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
    at /home/me/prj/ssb/patchwork/node_modules/packet-stream-codec/index.js:95:24
    at next (/home/me/prj/ssb/patchwork/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:14:9)
    at next (/home/me/prj/ssb/patchwork/node_modules/pull-stream/sinks/drain.js:16:11)
    at /home/me/prj/ssb/patchwork/node_modules/pull-stream/sinks/drain.js:29:15
    at /home/me/prj/ssb/patchwork/node_modules/pull-goodbye/node_modules/pull-stream/throughs/filter.js:17:11
Exception thrown by PacketStream substream end handler Error {}
Error: unexpected hangup
    at Object.cb (/home/me/prj/ssb/patchwork/node_modules/pull-box-stream/index.js:117:44)
    at drain (/home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:46:23)
    at /home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:63:18
    at /home/me/prj/ssb/patchwork/node_modules/pull-reader/index.js:114:13
    at drain (/home/me/prj/ssb/patchwork/node_modules/stream-to-pull-stream/index.js:126:18)
    at Socket.<anonymous> (/home/me/prj/ssb/patchwork/node_modules/stream-to-pull-stream/index.js:143:5)
    at Socket.emit (events.js:205:15)
    at endReadableNT (_stream_readable.js:1154:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:9)
...

and also a lot of

Exception thrown by PacketStream substream end handler Error { errno: 'ECONNRESET', code: 'ECONNRESET', syscall: 'read' }
Error: read ECONNRESET
    at Pipe.onStreamRead (internal/stream_base_commons.js:183:27)

Powersource · 2020-02-24T19:08:23Z

cc @staltz idk if you recognize those stack traces as being conn-related (I mean it doesn't mention conn but maybe an error that's propagated?)

staltz · 2020-02-24T19:34:28Z

@Powersource doesn't seem ssb-conn related to me. Those kind of errors have always been somewhat common in SSB since always.

arj03 · 2020-02-24T20:01:42Z

First of all, thanks for testing @Powersource

I'm with Staltz on the errors. These look like network errors? What happens if you run a sbot status? Mine right now looks like this:

~/dev/ssb-minimal-pub-server/bin.js status
{
  "progress": {
    "indexes": {
      "start": 838120964,
      "current": 838120964,
      "target": 838120964
    }
  },
  "sync": {
    "since": 838120964,
    "plugins": {
      "last": 838120964,
      "keys": 838120964,
      "clock": 838120964,
      "time": 838120964,
      "feed": 838120964,
      "contacts2": 838120964,
      "backlinks-6CAxOI3f-": 838120964,
      "ssb-chess-index": 838120964,
      "meme": 838120964,
      "private-6CAxOI3f-": 838120964,
      "query": 838120964,
      "search": 838120964,
      "unread-dummy-index": 838120964,
      "peer-invites": 838120964
    },
    "sync": true
  }
}

Powersource · 2020-02-25T12:44:04Z

Unfortunately started the regular client instead of this branch again so didn't get to see the index status. Will try to run this branch again now and try to reproduce.

Any way I agree that this issue is probably unrelated to this PR.

Powersource

since i don't think there's a button to remove my "request changes"

christianbundy · 2020-03-04T02:36:05Z

I don't know whether I remember 100% -- when we bump indexes should we be doing releases of all clients? I'm worried that if Patchwork releases with a new SSB-Backlinks then if someone opens and closes Patchwork and then switches to another client then they'll just keep deleting the backlinks directory and starting from scratch. Is that true, or am I tripping?

arj03 · 2020-03-04T08:06:20Z

Yes, patchbay is already upgraded ;)

christianbundy · 2020-03-04T16:26:51Z

Sweet, I'm down to merge ASAP. It looks like package.json and package-lock.json aren't in sync and Travis is failing, if you push a fix I'll merge or I'll try to get to it in the next few days.

arj03 · 2020-03-04T19:29:30Z

Thanks @christianbundy. I pushed a merge now.

christianbundy · 2020-03-04T19:48:31Z

I don't think it's a merge conflict, it looks like a conflict between package.json and package-lock.json. Does npm ci work for you locally? I think the fix is usually just npm install, which should update package-lock.json.

arj03 · 2020-03-04T20:02:25Z

Thanks. Latest commit should do it.

christianbundy · 2020-03-10T18:29:57Z

🎉

Bump ssb-backlinks

a09dec2

Powersource approved these changes Feb 24, 2020

View reviewed changes

Powersource suggested changes Feb 24, 2020

View reviewed changes

Powersource approved these changes Feb 25, 2020

View reviewed changes

Merge branch 'master' into upgrade-ssb-backlinks

7753452

Fix package-lock

21a7528

christianbundy merged commit b461d1f into master Mar 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump ssb-backlinks #1251

Bump ssb-backlinks #1251

arj03 commented Feb 20, 2020

christianbundy commented Feb 21, 2020

arj03 commented Feb 21, 2020

Powersource left a comment

Powersource left a comment

Powersource commented Feb 24, 2020

Powersource commented Feb 24, 2020

staltz commented Feb 24, 2020

arj03 commented Feb 24, 2020

Powersource commented Feb 25, 2020

Powersource left a comment

christianbundy commented Mar 4, 2020

arj03 commented Mar 4, 2020

christianbundy commented Mar 4, 2020

arj03 commented Mar 4, 2020

christianbundy commented Mar 4, 2020

arj03 commented Mar 4, 2020

christianbundy commented Mar 10, 2020

Bump ssb-backlinks #1251

Bump ssb-backlinks #1251

Conversation

arj03 commented Feb 20, 2020

christianbundy commented Feb 21, 2020

arj03 commented Feb 21, 2020

Powersource left a comment

Choose a reason for hiding this comment

Powersource left a comment

Choose a reason for hiding this comment

Powersource commented Feb 24, 2020

Powersource commented Feb 24, 2020

staltz commented Feb 24, 2020

arj03 commented Feb 24, 2020

Powersource commented Feb 25, 2020

Powersource left a comment

Choose a reason for hiding this comment

christianbundy commented Mar 4, 2020

arj03 commented Mar 4, 2020

christianbundy commented Mar 4, 2020

arj03 commented Mar 4, 2020

christianbundy commented Mar 4, 2020

arj03 commented Mar 4, 2020

christianbundy commented Mar 10, 2020