Use an array buffer for the sftp packet stream #1649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sftp packet stream runs within but independently of the channel data stream, meaning a channel data packet can contain multiple sftp packets, or an sftp packet can be split across multiple channel data packets. Normally the packets are sized such there is a 1-to-1 relationship for efficiency. When this doesn't happen the library falls back to buffering via a List<byte>, which is not so efficient. This change uses an array-based buffer instead. In a sample download which hit this fallback I see about a 20% reduction in memory allocated.
WojciechNagorski
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sftp packet stream runs within but independently of the channel data stream, meaning a channel data packet can contain multiple sftp packets, or an sftp packet can be split across multiple channel data packets.
Normally the packets are sized such there is a 1-to-1 relationship for efficiency. When this doesn't happen the library falls back to buffering via a List<byte>, which is not so efficient. This change uses an array-based buffer instead.
In a sample download which hit this fallback I see about a 20% reduction in memory allocated.