Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the subdevice range properties require their parent #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peternewman
Copy link
Contributor

Even if they're optional, when they are used they should require what they are ranging

Even if they're optional, when they are used they should require what they are ranging
@ssilverman
Copy link
Owner

ssilverman commented Sep 22, 2020

If someone wants to write a schema with "get_request_subdevice_range" and "set_request_subdevice_range", but without corresponding "get_request" and "set_request", that's up to them. These are fields that effectively annotate "get_request" and "set_request", so their presence shouldn't require them. They will do nothing. It's not the schema's job to detect badly-formed schema instances. That's a job for a linter tool.

@ssilverman
Copy link
Owner

Another way of putting it: My principle here is that annotations shouldn't require the thing they're annotating, at least in the schema validation level.

@ssilverman ssilverman force-pushed the master branch 2 times, most recently from 3e6d0c1 to ac42033 Compare August 23, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants