Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further validation #8

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

peternewman
Copy link
Contributor

This extends the validation in #6 by actually validating against our schema.

Copy link
Owner

@ssilverman ssilverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Copy link
Owner

@ssilverman ssilverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, @peternewman could you combine all the commits into one and force push?

@peternewman
Copy link
Contributor Author

Is the Squash and Merge option acceptable @ssilverman or do you want me to have a go from my end?

@ssilverman
Copy link
Owner

I'm familiar with squash merges, I just wanted to give you an opportunity to create your own commit message. If you don't want to, I'll just create a commit and give you credit in the comments.

@ssilverman
Copy link
Owner

See: #6 (comment)

@peternewman
Copy link
Contributor Author

I'm familiar with squash merges, I just wanted to give you an opportunity to create your own commit message. If you don't want to, I'll just create a commit and give you credit in the comments.

I thought I'd replied before, but seemingly not.

It strikes me the squash within GitHub's UI is probably the best option, you get to specify the commit message, which means you can standardise them and keep them consistent between contributors, where the GitHub squash will retain my authorship of all the commits in blame etc (as opposed to just a comment in a commit message).

Otherwise if you'd like to propose a commit message, I can do the squash in another branch and open yet another PR if you really don't want to use GitHub's squash UI yourself?

"Add jsonlint GitHub Action for automatic JSON validation"?

@ssilverman ssilverman force-pushed the master branch 2 times, most recently from 3e6d0c1 to ac42033 Compare August 23, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants