Bump flask-cors from 4.0.2 to 6.0.0 in /servicex_app #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [flask-cors](https://github.com/corydolphin/flask-cors) from 4.0.2 to 6.0.0. - [Release notes](https://github.com/corydolphin/flask-cors/releases) - [Changelog](https://github.com/corydolphin/flask-cors/blob/main/CHANGELOG.md) - [Commits](corydolphin/flask-cors@4.0.2...6.0.0) --- updated-dependencies: - dependency-name: flask-cors dependency-version: 6.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
This should be fine since we don't specify any specific CORS paths. Let's have an expert though. |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the flask-cors dependency in pyproject.toml from version 4.0.1 to 6.0.0 to address CVEs and apply breaking changes introduced upstream.
- Bumps
flask-corsfrom^4.0.1to^6.0.0 - Calls out new path specificity ordering and case sensitivity in CORS matching
Comments suppressed due to low confidence (2)
servicex_app/pyproject.toml:20
- After upgrading to flask-cors 6.0.0, add or update integration tests to cover the new path specificity ordering and case-sensitive matching changes to ensure CORS rules still behave as expected.
flask-cors = "^6.0.0"
servicex_app/pyproject.toml:20
- [nitpick] Consider updating project documentation or README to note the upgrade to flask-cors 6.0.0 and highlight any breaking changes (path ordering, case sensitivity) so consumers are aware.
flask-cors = "^6.0.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps flask-cors from 4.0.2 to 6.0.0.
Release notes
Sourced from flask-cors's releases.
Commits
35d8753[CVE-2024-6844] Replace use of (urllib) unquote_plus with unquote for paths (...e970988[CVE-2024-6839] Sort Paths by Regex Specificity (#391)eb39516[CVE-2024-6866] Case Sensitive Request Path Matching (#390)5da9be4Fix packaging: missing source files (#381)65a5132Workaround license publishing issue (#380)7127e7eAlways use trusted publishing (#379)01e2e68Fix release pipeline (#378)ade65a1Major Packaging Refactor: migrate to uv (#377)eb44bfffix: typos (#371)1225e78replace documentation links in README (#369)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.