Add error handling on the calls to the server to debug issue #132 #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
hey @tmeire sorry, just seeing this and i reworked init quite a bit! want to take a look at latest and see if your changes still apply? |
|
@adamdottv merged the changes from dev and moved the http status code checks to the new locations 👍 |
|
really sorry, things moved again, mind to rebase? also, we have toast messages now if you'd like to notify the user that way |
tmeire
force-pushed
the
fix/server-error-reporting
branch
from
2c4ef78 to
1294118
Compare
|
@adamdotdevin rebased again If it bails out on the providers cmd, it's still crashing because multiple parts in the rest of the code assume there's always a provider configured. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds HTTP response code checking on a couple of calls to the server.