feat(tui): add debounce logic to escape key interrupt #169
+76
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monotykamary
force-pushed
the
feat/escape-key-debounce
branch
from
0353d53 to
a97d81e
Compare
|
hey, things moved around a little bit, i think we want to move forward with this though; mind updating to work with the dynamic keybinds? |
…dental cancellations Implements a two-stage escape key mechanism where the first press shows "esc again interrupt" and requires a second press within 1 second to actually cancel the operation. This prevents users from accidentally interrupting long-running chat operations while maintaining responsive cancellation when intentional. 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
monotykamary
force-pushed
the
feat/escape-key-debounce
branch
from
0a1e8e3 to
a4ae83a
Compare
|
hopefully should be ok Screen.Recording.2025-06-21.at.13.49.30.mov |
|
sorry, i probably wasn't very clear on that last message. we actually have configurable interrupt keybind now, so we can't assume the user with use |
|
ah gotcha, let me have a look |
…tal cancellations Implements a two-stage interrupt key mechanism that works with any user-configured interrupt keybind (not just "esc"). The first press shows "esc again interrupt" and requires a second press within 1 second to actually cancel the operation. This prevents users from accidentally interrupting long-running chat operations while maintaining responsive cancellation when intentional. - Uses dynamic keybind matching instead of hardcoded "esc" key - Works with leader key sequences and custom interrupt keybinds - 1 second debounce timeout for optimal user experience - Real-time UI feedback with hint text updates 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
Updates the interrupt hint text to show the user's actual configured interrupt key instead of hardcoded "esc". Now displays the correct key text for any configured interrupt keybind (esc, ctrl+c, q, leader+key, etc.). - Gets interrupt key text from command registry during initialization - Updates hint display dynamically: "ctrl+c interrupt" → "ctrl+c again interrupt" - Removes unnecessary fallbacks for cleaner, more confident code - Handles first render correctly with proper initialization 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
|
hopefully should be ok now |
Instead of storing the interrupt key text, dynamically retrieve it from the app commands when needed. This reduces state duplication and ensures the displayed key always matches the configured command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Implements two-stage escape key mechanism to prevent accidental chat operation cancellations
• First escape press shows "esc again interrupt", second press within 2 seconds actually cancels
Screen.Recording.2025-06-17.at.20.24.33.mov
Test plan
🤖 Generated with opencode