Skip to content

fix: shimmer cpu cost #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
Merged

fix: shimmer cpu cost #2084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d6cd43
shimmer simplification
spoons-and-mirrors Aug 20, 2025
3b330b5
make it basoc
spoons-and-mirrors Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 35 additions & 40 deletions packages/tui/internal/util/shimmer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ import (
"github.com/sst/opencode/internal/styles"
)

var shimmerStart = time.Now()
var (
shimmerStart = time.Now()
trueColorSupport = hasTrueColor()
)

// Shimmer renders text with a moving foreground highlight.
// bg is the background color, dim is the base text color, bright is the highlight color.
Expand All @@ -32,7 +35,7 @@ func Shimmer(s string, bg compat.AdaptiveColor, _ compat.AdaptiveColor, _ compat
elapsed := time.Since(shimmerStart).Seconds()
pos := (math.Mod(elapsed, sweep) / sweep) * period

half := 4.0
half := 2.0

type seg struct {
useHex bool
Expand All @@ -41,60 +44,52 @@ func Shimmer(s string, bg compat.AdaptiveColor, _ compat.AdaptiveColor, _ compat
faint bool
text string
}
var segs []seg
segs := make([]seg, 0, n/4)

useHex := hasTrueColor()
useHex := trueColorSupport
for i, r := range runes {
ip := float64(i + pad)
dist := math.Abs(ip - pos)
t := 0.0
if dist <= half {
x := math.Pi * (dist / half)
t = 0.5 * (1.0 + math.Cos(x))
}
// Cosine brightness: base + amp*t (quantized for grouping)
base := 0.55
amp := 0.45
brightness := base
if t > 0 {
brightness = base + amp*t
}
lvl := int(math.Round(brightness * 255.0))
if !useHex {
step := 24 // ~11 steps across range for non-truecolor
lvl = int(math.Round(float64(lvl)/float64(step))) * step
}

bold := lvl >= 208
faint := lvl <= 128

// truecolor if possible; else fallback to modifiers only
bold := false
faint := true
hex := ""
if useHex {
if lvl < 0 {
lvl = 0
}
if lvl > 255 {
lvl = 255

if dist <= half {
// Simple 3-level brightness based on distance
if dist <= half/3 {
// Center: brightest
bold = true
faint = false
if useHex {
hex = "#ffffff"
}
} else {
// Edge: medium bright
bold = false
faint = false
if useHex {
hex = "#cccccc"
}
}
hex = rgbHex(lvl, lvl, lvl)
}

if len(segs) == 0 {
if len(segs) == 0 ||
segs[len(segs)-1].useHex != useHex ||
segs[len(segs)-1].hex != hex ||
segs[len(segs)-1].bold != bold ||
segs[len(segs)-1].faint != faint {
segs = append(segs, seg{useHex: useHex, hex: hex, bold: bold, faint: faint, text: string(r)})
} else {
last := &segs[len(segs)-1]
if last.useHex == useHex && last.hex == hex && last.bold == bold && last.faint == faint {
last.text += string(r)
} else {
segs = append(segs, seg{useHex: useHex, hex: hex, bold: bold, faint: faint, text: string(r)})
}
segs[len(segs)-1].text += string(r)
}
}

baseStyle := styles.NewStyle().Background(bg)
var b strings.Builder
b.Grow(len(s) * 2)
for _, g := range segs {
st := styles.NewStyle().Background(bg)
st := baseStyle
if g.useHex && g.hex != "" {
c := compat.AdaptiveColor{Dark: lipgloss.Color(g.hex), Light: lipgloss.Color(g.hex)}
st = st.Foreground(c)
Expand Down
Loading