Skip to content

fix: recognize dotted property names in index extraction - #468

Open
pantierra wants to merge 1 commit into
stac-utils:mainfrom
pantierra:fix/dotted-index
Open

fix: recognize dotted property names in index extraction#468
pantierra wants to merge 1 commit into
stac-utils:mainfrom
pantierra:fix/dotted-index

Conversation

@pantierra

Copy link
Copy Markdown
Contributor

Technical Context

Description

queryable_indexes() (and the pgstac_indexes/pgstac_indexes_stats views) extract property names from index definitions using a regex whose character class excludes .. Dotted queryable names (e.g. monty:impact_detail.value) fail to match.

Because the field can't be extracted, pgSTAC doesn't recognize existing indexes on dotted fields, so maintain_partitions() creates a new duplicate index every reload/sync instead of no-oping.

Therefore I suggest we widen the capture group to allow . (and other valid STAC path chars): [a-zA-Z0-9:_.-]+.


Checklist

  • Linting: Does not apply for SQL-only change.
  • Tests: Tests pass. I have included new tests for these changes where applicable.
  • Edge Cases: I have manually verified "unhappy paths" and edge cases beyond the basic success criteria (e.g., database connection timeouts, malformed input, strict mapping rejections).
  • Documentation: Added to CHANGELOG.md. No need for more documentation
  • Accountability: I can explain the implementation logic for every line of code submitted.

AI tool usage

  • AI (Copilot or something similar) supported my development of this PR. See our policy about AI tool use. Use of AI tools must be indicated.

Policy: We require a "human-in-the-loop." You are the author and are fully accountable for all submitted code. Please ensure all tool-generated content is thoroughly reviewed before submission to ensure it is not an "extractive contribution" that squanders maintainer time.

@pantierra
pantierra force-pushed the fix/dotted-index branch 3 times, most recently from 0411086 to 1e440da Compare July 21, 2026 16:12
@pantierra pantierra changed the title fix: recognize dotted queryable property names in index extraction fix: recognize dotted property names in index extraction Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant