implementation for archive extension #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for opening a PR @kmodali! It might take me a few days to get around to reviewing, but it is on my list! |
jsignell
reviewed
Dec 1, 2025
Member
jsignell
left a comment
jsignell
left a comment
There was a problem hiding this comment.
I recognize that this PR might be in a partial state, but now that I've (finally!) read it over I feel pretty convinced that this logic doesn't belong in xpystac. It should be the responsibility of the zarr backend to make sense of an archived zarr file. So while xpystac might need to add a little logic to understand how to hand off metadata from the archive extension fields it shouldn't be in charge of any caching or extracting.
| default_kwargs: Mapping = {"chunks": {}} | ||
|
|
||
| # Check the type of the 'obj' | ||
| if isinstance(obj, pystac.Asset): |
Member
There was a problem hiding this comment.
This should always evaluate to true since this function is registered for the case where obj is an Asset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling STAC items with tar assets, either single tar or list of tars.