-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Add boil tool #1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add boil tool #1224
Conversation
Only send out notifications if the build failed, a build is re-run and wasn't cancelled.
Worth pointing out that when this merges, bake will no longer work. |
Oh yeah, good point. I will add it to the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried running cargo boil build airflow
. Got this as a result:
WARNING: No output specified for entry--airflow-2_10_4, entry--airflow-2_10_5, entry--airflow-2_9_3, entry--airflow-3_0_1 target(s) with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
Successfully built 4 images:
oci.stackable.tech/sdp/airflow:2.10.4-stackable0.0.0-dev-amd64
oci.stackable.tech/sdp/airflow:2.10.5-stackable0.0.0-dev-amd64
oci.stackable.tech/sdp/airflow:2.9.3-stackable0.0.0-dev-amd64
oci.stackable.tech/sdp/airflow:3.0.1-stackable0.0.0-dev-amd64
Images weren't there and running cargo boil build airflow --load
or cargo boil build airflow -- --load
didn't work.
There were a bunch of small errors in the new boil-config.toml files. These are now fixed and should contain the same data as the versions.py files before. Co-authored-by: Xenia <[email protected]>
The first of these two commands now works. In 65bab9c I've added the |
Tested the commands from the README
They worked for me now, thanks for adding the Just some minor things I noticed while trying them out (don't need to be addressed if they have no consequences, just noting them down):
|
This is a warning emitted from Docker and should not be connected with any of the changes in tooling.
They are now correctly tagged, because previously the images were tagged without the architecture, indicating it is a multi-arch image, even tho it was only ever one architecture (the one you specify, or But let me know what we can maybe do to improve working with these images locally. One idea might be to tag them with and without the architecture suffix if a |
Caution
Once this merges,
bake
will no longer be compatible with this repository. As such, the GHA workflow needs to be adjusted to work withboil
.Note
This was ✨ magically ✨ developed in my spare time and I'm happy to fully hand over this code to Stackable.
This PR adds
boil
, a replacement forbake
written in Rust.bake --preflight
command is for example currently broken on main (even if unused)._VERSION
to local image versions ARGsdocker
)I additionally have some cool ideas (dealing with supported product versions for example), but I don't wanna spoil them just yet.