Skip to content

Add ZOOCFGDIR env variable to ZooKeeper to make scripts work #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

Add ZOOCFGDIR env variable to ZooKeeper to make scripts work #1298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions zookeeper/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ EOF

ENV ZOOKEEPER_HOME=/stackable/zookeeper
ENV PATH="${PATH}":/stackable/zookeeper/bin
# This is used by zkEnv.sh and for the shell scripts in bin/
# If unset it tries to find the conf directory automatically and that fails
ENV ZOOCFGDIR=/stackable/config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we have a rwconfig as well for the real config https://github.com/stackabletech/zookeeper-operator/blob/e370101dfe986e862c0354f6a50471b857d0c078/rust/operator-binary/src/zk_controller.rs#L927.
Its created by the operator though...maybe this should be set in the operator?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this to be honest. Is /stackable/config the wrong directory then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We basically use the config mounted in /stackable/config, copy that to /stackable/rwconfig to replace/extend the myid etc. A quick glance does not show anything else https://github.com/stackabletech/zookeeper-operator/blob/main/rust/operator-binary/src/command.rs#L3. We do more in other operators.

Thats why the tests probably work fine, just wanted to say that the config file stored in /stackable/config is not the one zookeeper runs with, see https://github.com/stackabletech/zookeeper-operator/blob/e370101dfe986e862c0354f6a50471b857d0c078/rust/operator-binary/src/zk_controller.rs#L955.

And the rwconfig is an empty dir created by the operator.


USER ${STACKABLE_USER_UID}
WORKDIR /stackable/zookeeper
Expand Down
Loading