feat: Hive listener integration #605
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I might have run into stackabletech/hdfs-operator#686 during development. I recognized that I can have an empty string in my discovery configMap from time to time. Behaviour appears to be flaky, but yet more often then not the emtpy string appears: ExpectedFlaky faulty one |
…tackabletech/hive-operator into feat/hive-listener-integration
|
🟢 |
Maleware
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
maltesander
requested changes
Jun 10, 2025
maltesander
reviewed
Jun 10, 2025
Co-authored-by: Malte Sander <[email protected]>
…tackabletech/hive-operator into feat/hive-listener-integration
Co-authored-by: Malte Sander <[email protected]>
…tackabletech/hive-operator into feat/hive-listener-integration
Comment on lines
135
to
140
| listener_ref: Listener, | ||
| rolegroup: &String, | ||
| chroot: Option<&str>, | ||
| ) -> Result<String, Error> { | ||
| // We only need the first address corresponding to the rolegroup | ||
| let listener_address = listener_ref |
There was a problem hiding this comment.
This should probably be called listener, as it isn't a ref.
Suggested change
| listener_ref: Listener, | |
| rolegroup: &String, | |
| chroot: Option<&str>, | |
| ) -> Result<String, Error> { | |
| // We only need the first address corresponding to the rolegroup | |
| let listener_address = listener_ref | |
| listener: Listener, | |
| rolegroup: &String, | |
| chroot: Option<&str>, | |
| ) -> Result<String, Error> { | |
| // We only need the first address corresponding to the rolegroup | |
| let listener_address = listener |
There was a problem hiding this comment.
Is gone as not needed anymore
rust/operator-binary/src/crd/mod.rs
Outdated
| @@ -448,6 +417,10 @@ pub struct MetaStoreConfig { | |||
| /// Time period Pods have to gracefully shut down, e.g. `30m`, `1h` or `2d`. Consult the operator documentation for details. | |||
| #[fragment_attrs(serde(default))] | |||
| pub graceful_shutdown_timeout: Option<Duration>, | |||
|
|
|||
| /// This field controls which [ListenerClass](DOCS_BASE_URL_PLACEHOLDER/listener-operator/listenerclass.html) is used to expose the webserver. | |||
| #[serde(default)] | |||
There was a problem hiding this comment.
All other fields use fragment_attr, is that needed here too?
Suggested change
| #[serde(default)] | |
| #[fragment_attr(serde(default))] |
There was a problem hiding this comment.
Also, do we want the String::default() to be called? Doesn't it have to be a valid class, or it falls back to cluster-internal?
There was a problem hiding this comment.
also outdated I think.
Yes, now it falls back to cluster-internal if listenerClass is not given.
| hive, | ||
| &resolved_product_image.app_version_label, | ||
| &HiveRole::MetaStore.to_string(), | ||
| "discovery", |
There was a problem hiding this comment.
Would this cause a collision if there are multiple role groups defined?
There was a problem hiding this comment.
Also outdated as it's on role level now
Maleware
moved this from Development: In Review
to Development: In Progress
in Stackable Engineering
maltesander
requested changes
Jun 20, 2025
Comment on lines
508
to
530
| // Init listener struct. Collect listener after applied to cluster_resources | ||
| // to use listener object in later created discovery configMap | ||
| let mut listener = Listener::new("name", ListenerSpec::default()); | ||
| let role_config = hive.role_config(&hive_role); | ||
| if let Some(GenericRoleConfig { | ||
| pod_disruption_budget: pdb, | ||
| if let Some(HiveMetastoreRoleConfig { | ||
| common: GenericRoleConfig { | ||
| pod_disruption_budget: pdb, | ||
| }, | ||
| listener_class, | ||
| }) = role_config | ||
| { | ||
| add_pdbs(pdb, hive, &hive_role, client, &mut cluster_resources) | ||
| .await | ||
| .context(FailedToCreatePdbSnafu)?; | ||
|
|
||
| let group_listener: Listener = | ||
| build_group_listener(hive, &resolved_product_image, &hive_role, listener_class)?; | ||
| listener = cluster_resources | ||
| .add(client, group_listener) | ||
| .await | ||
| .with_context(|_| ApplyGroupListenerSnafu { | ||
| role: hive_role.to_string(), | ||
| })?; |
There was a problem hiding this comment.
I would split the pdbs and listener stuff like so:
let role_config = hive.role_config(&hive_role);
if let Some(HiveMetastoreRoleConfig {
common: GenericRoleConfig {
pod_disruption_budget: pdb,
},
..
}) = role_config
{
add_pdbs(pdb, hive, &hive_role, client, &mut cluster_resources)
.await
.context(FailedToCreatePdbSnafu)?;
}
// std's SipHasher is deprecated, and DefaultHasher is unstable across Rust releases.
// We don't /need/ stability, but it's still nice to avoid spurious changes where possible.
let mut discovery_hash = FnvHasher::with_key(0);
if let Some(HiveMetastoreRoleConfig { listener_class, .. }) = role_config {
let group_listener: Listener =
build_group_listener(hive, &resolved_product_image, &hive_role, listener_class)?;
let listener = cluster_resources
.add(client, group_listener)
.await
.context(ApplyGroupListenerSnafu {
role: hive_role.to_string(),
})?;
for discovery_cm in discovery::build_discovery_configmaps(
hive,
hive,
hive_role,
&resolved_product_image,
None,
listener,
)
.await
.context(BuildDiscoveryConfigSnafu)?
{
let discovery_cm = cluster_resources
.add(client, discovery_cm)
.await
.context(ApplyDiscoveryConfigSnafu)?;
if let Some(generation) = discovery_cm.metadata.resource_version {
discovery_hash.write(generation.as_bytes())
}
}
}
Comment on lines
990
to
991
| let recommended_object_labels: ObjectLabels<'_, v1alpha1::HiveCluster> = | ||
| build_recommended_labels( |
There was a problem hiding this comment.
Overlooked it. Probably IDE autocompletion whenever you double click the type :(
| obj_ref: ObjectRef<Service>, | ||
| }, | ||
| #[snafu(display("could not find port [{port_name}] for rolegroup listener {role}"))] | ||
| NoServicePort { port_name: String, role: String }, | ||
| #[snafu(display("service [{obj_ref}] port [{port_name}] does not have a nodePort "))] | ||
| NoNodePort { |
There was a problem hiding this comment.
NoNodePort, FindEndpoints, InvalidNodePort etc. unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds listener Support
Definition of Done Checklist
Author
Reviewer
Acceptance