-
-
Notifications
You must be signed in to change notification settings - Fork 9
chore: add built-in Prometheus support #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but this is worth mentioning in the docs too, especially the metric endpoints and maybe adding an assert step in a kuttl test. Maybe smoke ?
b5a685d (expanded test)
Working on some documentation next Edit: Updated docs fa8597e |
The metrics port is hard coded in a couple of places:
|
Rerun of tests after readding jmx exporter
|
Co-authored-by: Razvan-Daniel Mihai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Part of #954
Docs added here: https://docs.stackable.tech/home/nightly/zookeeper/usage_guide/monitoring/
Integrationtests
Openshift
Release Note Snippet
Prometheus support was added using the built-in Prometheus provider in ZooKeeper. This appends another port (
native-metrics
). To access the metrics this port in combination with the/metrics
endpoint can be used.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecation
label & add to the deprecation scheduletype/experimental
label & add to the experimental features tracker