feat(native): Add toBeVisible #145
Open
+200
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suany0805
reviewed
Mar 24, 2025
suany0805
reviewed
Mar 24, 2025
JoseLion
reviewed
Apr 24, 2025
kdquistanchala
force-pushed
the
feat/native-to-be-visible
branch
from
35e5052 to
82fa78b
Compare
lopenchi
force-pushed
the
feat/native-to-be-visible
branch
from
4cfe69c to
dcded59
Compare
JoseLion
reviewed
Jul 17, 2025
| @@ -42,7 +42,7 @@ export class ElementAssertion extends Assertion<ReactTestInstance> { | |||
| } | |||
|
|
|||
| /** | |||
| * Check if the component is enabled. | |||
| * Check if the component is enabled and has not been disabled by an ancestor. | |||
| }); | ||
|
|
||
| return this.execute({ | ||
| assertWhen: this.isElementVisible(this.actual) && !this.isAncestorNotVisible(this.actual), |
There was a problem hiding this comment.
I' reading the second condition like "...and not is ancestor not visible" which is weird 😅 Would it make more sense to invert the logic of the function and change it's name to isAncestorVisible(..)?
| private isElementVisible(element: ReactTestInstance): boolean { | ||
| const { type } = element; | ||
| const elementType = type.toString(); | ||
| if (elementType === "Modal" && !element?.props?.visible === true) { |
There was a problem hiding this comment.
!element?.props?.visible === trueThis one is also very hard to read. So we first negate the value of an optional prop and the compare it to true? 😖 Is there a better way to write this condition?
Co-authored-by: Jose Luis Leon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
toBeVisiblematcher for React Native