support audio embeds #2533
Open
support audio embeds #2533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #2526
this implementation add native audio file embedding, allowing user to embed direct audio files links as playable HTML5 audio players within posts and comments.
Extended
parseEmbedUrl()for audio file detection;Added new "audio" provider to embed framework;
Extended
useMediaHelperwith audio detection cascade;Integrated with existing
MediaOrLinkcomponent;Added CSS styling with theme compatibily.
Screenshots
2025-09-14-20-55-58.mp4
Additional Context
Audio detection is positioned early in
parseEmbedUrl()to catch file links before other providers, uses both embed framework and media helper to garant a fallback if one fails,supports query parameters in URLs (e.g.,
file.mp3?version=1), used!importantCSS override to prevent margin inheritance from general embed rules,implemented audio detection cascade in
useMediaHelperto maintain existing video/image logic, addedpreload='metadata'for performance while avoiding automatic downloadsChecklist
Are your changes backward compatible? Please answer below:
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8/10
For frontend changes: Tested on mobile, light and dark mode? Please answer below: yes
Did you introduce any new environment variables? If so, call them out explicitly here:
NaN
Did you use AI for this? If so, how much did it assist you?
I used AI to understand the context and identify the files to be modified, I asked for some implementation advice but the changes were all carefully considered and applied manually