Wallet improvements #2572
Open
Wallet improvements #2572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzyis
force-pushed
the
wallets
branch
5 times, most recently
from
54f2765 to
e6e391e
Compare
Draft
ekzyis
force-pushed
the
wallets
branch
2 times, most recently
from
7975b1b to
54e0cf8
Compare
|
Just to be clear: not preferring 5 one-line PRs modifying the same 10 lines of code, all so closely related to each other that they practically conflict on all lines when merged out of order, does not mean we want big vague PRs. We're looking for goldilocks PRs - not as small as possible but also not a PR that's like here's everything I did this week. Given that you "own" the wallet code, this PR is fine by me, but you didn't need to do this retroactively. I know you understand this, but I feel like you're being kind of rigid, trying to treat PR size like a bunch of fixed rules, an algorithm, rather than an also vibes thing. It's as much an art as it is a science. |
* Move passphrase hooks into own file * Rename to draggable.js to dnd.js * Create wallets/lib/crypto.js * Move wallets/client/context stuff into ../hooks The distinction between context and hooks did not make sense. * Fix circular imports within wallets/client/hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
supersedes #2546 #2552 #2553 #2554
see description in individual PRs + commit messages
Additional context
For me personally, it is definitely better to just have one big PR because I know what I did and then I can resolve conflicts between commits immediately. If I want to use the web interface to review and document my changes, I can also push to my own repository and do it there.
The small PRs were mostly meant to make review easier, but since that is apparently not really the case, I now squashed every individual PR into one commit that I added here.
I hope that is better.
Checklist
Are your changes backward compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
tested PRs individually before
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no
Did you use AI for this? If so, how much did it assist you?
no