-
Notifications
You must be signed in to change notification settings - Fork 28
Merge upstream master #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Change-Id: I0938f3a10a0c308c3ed25d48e2cf4648527e8670 Signed-off-by: Pierre Riteau <[email protected]>
TinyIPA images were removed and none are published for 2025.2. Use 2025.1 images until we support CentOS Stream IPA images. Change-Id: I302050ac25d6e20fca2aefc1b89d4ec262eedfe3 Signed-off-by: Pierre Riteau <[email protected]>
Change-Id: I5f24d73248bbf21f3e856aea6dd1f6c6d3ce8735 Signed-off-by: Pierre Riteau <[email protected]>
Summary of ChangesHello @priteau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the project's configuration to align with newer operating system versions, specifically Rocky Linux 10 and CentOS Stream 10, and the latest OpenStack release, 2025.2. It includes significant changes to default image URLs, bootstrap user comments, and Ironic Inspector settings. Additionally, the CI pipeline has been updated to reflect these OS version changes, and some deprecated Kolla service configurations have been cleaned up. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request incorporates a significant number of updates from an upstream source, primarily focused on upgrading component versions and aligning with recent architectural changes. Key changes include updating the supported OS versions to CentOS/Rocky 10, bumping the default OpenStack release to 2025.2, and reflecting the integration of Ironic Inspector into Ironic itself. The CI configuration has also been updated accordingly. My review found one area for improvement regarding tracking technical debt. Overall, the changes appear to be a consistent and necessary synchronization with upstream.
| # Name of the current OpenStack release. Default is "2025.2". | ||
| #openstack_release: | ||
|
|
||
| # Name of the current OpenStack branch. Default is "master". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan here to merge this change, cut a 2025.2 branch, then merge again to reset this to master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
No description provided.