Skip to content

Conversation

@priteau
Copy link
Member

@priteau priteau commented Nov 14, 2025

No description provided.

Change-Id: I0938f3a10a0c308c3ed25d48e2cf4648527e8670
Signed-off-by: Pierre Riteau <[email protected]>
TinyIPA images were removed and none are published for 2025.2. Use
2025.1 images until we support CentOS Stream IPA images.

Change-Id: I302050ac25d6e20fca2aefc1b89d4ec262eedfe3
Signed-off-by: Pierre Riteau <[email protected]>
Change-Id: I5f24d73248bbf21f3e856aea6dd1f6c6d3ce8735
Signed-off-by: Pierre Riteau <[email protected]>
@priteau priteau self-assigned this Nov 14, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @priteau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the project's configuration to align with newer operating system versions, specifically Rocky Linux 10 and CentOS Stream 10, and the latest OpenStack release, 2025.2. It includes significant changes to default image URLs, bootstrap user comments, and Ironic Inspector settings. Additionally, the CI pipeline has been updated to reflect these OS version changes, and some deprecated Kolla service configurations have been cleaned up.

Highlights

  • Operating System Updates: Default OS release versions for CentOS and Rocky Linux have been updated from version 9 to version 10 across various configuration files, including globals.yml, infra-vms.yml, and seed-vm.yml.
  • OpenStack Release Alignment: The default OpenStack release and branch have been updated from 'master' to '2025.2' and 'stable/2025.2' respectively in openstack.yml.
  • Ironic Inspector Configuration Refinements: Several Ironic Inspector variables have been renamed, removed, or had their default values clarified in bifrost.yml and inspector.yml. Notably, the 'Inspection store configuration' section has been removed from inspector.yml.
  • Kolla Service Enablement Changes: Deprecated or unused Kolla service enablement flags such as kolla_enable_bifrost, kolla_enable_horizon_venus, kolla_enable_ironic_inspector, kolla_enable_redis, and kolla_enable_venus have been removed from kolla.yml. New flags kolla_enable_ironic_pxe_filter and kolla_enable_valkey were added.
  • CI Job Updates: Zuul CI jobs in zuul.d/project.yaml have been updated to reflect the transition from Rocky 9 to Rocky 10, with corresponding job names and voting statuses adjusted.
  • Temporary IPA Image Fix: A temporary fix has been applied to ipa_images_upstream_url_suffix in ipa.yml to address the removal of TinyIPA, pending support for CentOS Stream IPA images in CI.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request incorporates a significant number of updates from an upstream source, primarily focused on upgrading component versions and aligning with recent architectural changes. Key changes include updating the supported OS versions to CentOS/Rocky 10, bumping the default OpenStack release to 2025.2, and reflecting the integration of Ironic Inspector into Ironic itself. The CI configuration has also been updated accordingly. My review found one area for improvement regarding tracking technical debt. Overall, the changes appear to be a consistent and necessary synchronization with upstream.

# Name of the current OpenStack release. Default is "2025.2".
#openstack_release:

# Name of the current OpenStack branch. Default is "master".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan here to merge this change, cut a 2025.2 branch, then merge again to reset this to master?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants