Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iommu update for Rocky Linux 9 #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Iommu update for Rocky Linux 9 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fabb79
Change conditional to search for 'Intel'
technowhizz Mar 27, 2024
20708e9
Add support for specfying vfio id's
technowhizz Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions roles/iommu/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,19 @@
become: true

```

Or if you want the node to reboot automatically

```
---
- name: Enable IOMMU
hosts: iommu
tasks:
- import_role:
name: stackhpc.linux.iommu
handlers:
- name: reboot
reboot:
become: true

```
8 changes: 8 additions & 0 deletions roles/iommu/handlers/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
- name: Regenerate initramfs
ansible.builtin.shell: |-
#!/bin/bash
set -eux
dracut -v -f /boot/initramfs-$(uname -r).img $(uname -r)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be careful not to break ubuntu

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://help.ubuntu.com/community/Update%20the%20Ramdisk

become: true
changed_when: true
37 changes: 34 additions & 3 deletions roles/iommu/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,44 @@
---
- name: Template dracut config for vfio
ansible.builtin.blockinfile:
path: /etc/dracut.conf.d/gpu-vfio.conf
block: |
add_drivers+="vfio vfio_iommu_type1 vfio_pci vfio_virqfd"
owner: root
group: root
mode: "0660"
create: true
become: true
when: iommu_vfio_pci_ids is defined
notify:
- Regenerate initramfs
- reboot

- name: Add vfio to modules-load.d
ansible.builtin.blockinfile:
path: /etc/modules-load.d/vfio.conf
block: |
vfio
vfio_iommu_type1
vfio_pci
vfio_virqfd
owner: root
group: root
mode: "0664"
create: true
become: true
when: iommu_vfio_pci_ids is defined
notify: reboot

- name: Add iommu to kernel command line (Intel)
ansible.builtin.include_role:
name: stackhpc.linux.grubcmdline
vars:
kernel_cmdline: # noqa: var-naming[no-role-prefix]
- intel_iommu=on
kernel_cmdline: "{{ ['intel_iommu=on'] + (['vfio-pci.ids=' + iommu_vfio_pci_ids] if iommu_vfio_pci_ids is defined else []) }}" # noqa: var-naming[no-role-prefix]
kernel_cmdline_remove: # noqa: var-naming[no-role-prefix]
- ^intel_iommu=
when: "'Intel' in ansible_facts.processor.0"
- ^vfio-pci\.ids=
when: ansible_facts.processor | select('search', 'Intel') | list | length > 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe vfio-pci is relevant for non-Intel processors too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I am not sure how the previous when clause even worked. Even on CentOS Stream 8, I see ansible_facts.processor looks like this:

  ansible_facts.processor:
  - '0'
  - GenuineIntel
  - Intel(R) Xeon(R) Gold 6146 CPU @ 3.20GHz
  - '1'
  - GenuineIntel
  - Intel(R) Xeon(R) Gold 6146 CPU @ 3.20GHz

So ansible_facts.processor.0 is always a string set to 0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with different Ansible versions for Yoga and for 2023.1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpu_facts come from /proc/cpuinfo - I've seen it returning 0 in the first line and GenuineIntel in the first line, maybe there was some bug in the past that caused lack of '0' in the first line


- name: Set iommu=pt
ansible.builtin.include_role:
Expand Down