Skip to content

Increase delay before trying to enable sriov #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

Conversation

jovial
Copy link
Collaborator

@jovial jovial commented Apr 10, 2025

Starting this too early gets the cards into a bad state. You get the following error when trying to start an mdev device:

stderr: 'Error: Parent 0000:81:00.4 is not currently registered for mdev support'

Starting this too early gets the cards into a bad state. You get the following error when trying to start an mdev device:

```
stderr: 'Error: Parent 0000:81:00.4 is not currently registered for mdev support'
```
@jovial jovial requested a review from a team as a code owner April 10, 2025 14:54
@hkominos
Copy link

Perhaps instead of a default value of 30 which is a long time, you can consider
{{ sriov_init_timeout | default('30') }} as an extra variable?

grzegorzkoper
grzegorzkoper previously approved these changes Apr 10, 2025
Copy link
Contributor

@grzegorzkoper grzegorzkoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Fixed an issue on a customer site.

@jovial
Copy link
Collaborator Author

jovial commented Apr 10, 2025

Perhaps instead of a default value of 30 which is a long time, you can consider {{ sriov_init_timeout | default('30') }} as an extra variable?

Good suggestion - I'll implement that @hkominos

Copy link
Contributor

@grzegorzkoper grzegorzkoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks even better +1

@jovial jovial merged commit 4b03cfd into main Apr 10, 2025
4 checks passed
@jovial jovial deleted the bugfix/sriov-mange-delay branch April 10, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants