Skip to content

Allow MIG devices to be defined without creating vGPUs #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 21, 2025
Merged

Conversation

jovial
Copy link
Collaborator

@jovial jovial commented Apr 15, 2025

  • NVIDIA driver installation can be skipped with: vgpu_nvidia_driver_install_enabled. This allows you to use alternative installation mechanism.
  • MIG devices can now be defined without a corresponding virtual_function (vGPU).
  • mig-parted has been bumped from v0.5 to v0.12

jovial added 5 commits April 15, 2025 10:30
This is useful if you already have an nvidia driver installed.
The command to enable will exit with non-zero status if you attempt to
enable mig mode and it is already enabled.
@jovial jovial marked this pull request as ready for review April 22, 2025 15:53
@jovial jovial requested a review from a team as a code owner April 22, 2025 15:53
Alex-Welsh
Alex-Welsh previously approved these changes May 9, 2025
Alex-Welsh
Alex-Welsh previously approved these changes May 21, 2025
@jovial jovial enabled auto-merge (squash) May 21, 2025 11:22
Copy link

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the role actually did support MIG configuration already, just not idempotently? Not sure if PR title needs changing.

@jovial jovial changed the title Support MIG configuration Allow MIG devices to be defined without creating vGPUs May 21, 2025
@sjpb sjpb self-requested a review May 21, 2025 14:22
Copy link

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovial jovial merged commit 6e3c4b3 into main May 21, 2025
4 checks passed
@jovial jovial deleted the feature/mig-only branch May 21, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants