Skip to content

Fix various typos #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix various typos #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions roles/vgpu/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ When creating MIG devices with no vGPU instances layered on top, there are no sp

The role will attempt to install a driver from ``vgpu_driver_url``. Currently this only works with
the data center drivers such as the
[Nvidia GRID drivers](https://docs.nvidia.com/grid/latest/grid-software-quick-start-guide/index.html#redeeming-pak-and-downloading-grid-software)
[NVIDIA GRID drivers](https://docs.nvidia.com/grid/latest/grid-software-quick-start-guide/index.html#redeeming-pak-and-downloading-grid-software)
or the [AI enterprise drivers](https://www.nvidia.com/en-gb/data-center/products/ai-enterprise/);
both of which can be obtained from the NVIDIA licensing portal. The use of data centre drivers is not mandatory
if you only want to use MIG without vGPUs.
Expand Down Expand Up @@ -169,7 +169,7 @@ Example of templated unit file:

```
[Unit]
Description=Enable SR-IOV on Nvidia card (0000:17:00.0)
Description=Enable SR-IOV on NVIDIA card (0000:17:00.0)
Before=nvidia-mig-manager.service
DefaultDependencies=no
After=local-fs.target sys-devices-pci0000:16-0000:16:02.0-0000:17:00.0.device
Expand Down
2 changes: 1 addition & 1 deletion roles/vgpu/tasks/gpu-facts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
# TODO: submit bug report to nvidia-mig-manger about not supporting PCI IDs
# TODO: submit bug report to nvidia-mig-manager about not supporting PCI IDs

- name: Look up card index
ansible.builtin.command: nvidia-smi -i {{ vgpu_definition.pci_address }} --query-gpu="index" --format csv,noheader
Expand Down
9 changes: 5 additions & 4 deletions roles/vgpu/templates/nvidia-sriov.service.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=Enable SR-IOV on Nvidia card ({{ vgpu_definition.pci_address }})
Description=Enable SR-IOV on NVIDIA card ({{ vgpu_definition.pci_address }})
Before=nvidia-mig-manager.service
DefaultDependencies=no
After=local-fs.target {{ vgpu_systemd_device[vgpu_definition.pci_address] }}
Expand All @@ -15,9 +15,10 @@ User=root
# I was unable to get this to show up again without a reboot.
ExecStartPre=/bin/sleep {{ vgpu_sriov_init_delay }}
# NOTE(wszumski): The sriov-manage script will unbind the nvidia driver to
# initialize the virtual functions. If it fails part way through, the driver
# can be left unbound, and subsequent executions of sriov-mange will fail. This
# ensures that the nvidia driver is always bound before we run sriov-manage.
# initialize the virtual functions. If it fails part way through, the driver
# can be left unbound, and subsequent executions of sriov-manage will fail.
# This ensures that the nvidia driver is always bound before we run
# sriov-manage.
ExecStart=/bin/bash -c "echo '{{ vgpu_definition.pci_address }}' > /sys/bus/pci/drivers/nvidia/bind || true"
ExecStart=/usr/lib/nvidia/sriov-manage -e {{ vgpu_definition.pci_address }}
RemainAfterExit=yes
Expand Down
8 changes: 4 additions & 4 deletions roles/vxlan/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
VXLAN
=========

This role creates persistent VXLAN interfaces with the use of [Network Scripts](https://pkgs.org/download/network-scripts), [NetworkManger](https://pkgs.org/download/NetworkManager), or [Systemd-Networkd](https://www.freedesktop.org/software/systemd/man/systemd-networkd.service.html).
This role creates persistent VXLAN interfaces with the use of [Network Scripts](https://pkgs.org/download/network-scripts), [NetworkManager](https://pkgs.org/download/NetworkManager), or [Systemd-Networkd](https://www.freedesktop.org/software/systemd/man/systemd-networkd.service.html).

Role Variables
--------------
Expand All @@ -16,16 +16,16 @@ The role uses the same variable names as `Network Scripts`. It is recommended to

`vxlan_dstport`: set the port for the VXLAN to reside on

`vxlan_bootproto`: specify boot protocol used with the interface (unsupported when using NetworkManger or Systemd-Networkd, always none)
`vxlan_bootproto`: specify boot protocol used with the interface (unsupported when using NetworkManager or Systemd-Networkd, always none)

`vxlan_onboot`: set to `yes` if the VXLAN interface should be brought up on boot otherwise `no` (Not supported on Systemd-networkd)

`vxlan_interfaces`: list of interfaces to be created can set specific instances of the variables defined above in addition to some others
> `device`: name assigned the VXLAN interface
>
> `ipaddr`: the IPV4 address assigned to the VXLAN interface (unsupported when using NetworkManger or Systemd-Networkd)
> `ipaddr`: the IPV4 address assigned to the VXLAN interface (unsupported when using NetworkManager or Systemd-Networkd)
>
> `prefix`: the subnet mask use with the `ipaddr` (unsupported when using NetworkManger or Systemd-Networkd)
> `prefix`: the subnet mask use with the `ipaddr` (unsupported when using NetworkManager or Systemd-Networkd)
>
> `group`: the multicast group the VXLAN will operate on
>
Expand Down