Wait for network config before activating libvirt socket #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the network configuration to complete before trying to activate the libvirt socket. This prevents systemd binding to the specified IP, then having the interface either come up or reconfigure.
Due to the race-y nature of the network config (at least with NetworkManager) and the socket activation this would mean <50% of the machines rebooting would be affected. After this point the socket is "up" from systemd's POV however anything (including telnet) trying to open the port will find it closed until an administrator restarts the socket unit