Skip to content

Refactor toplevel site.yml and fatimage.yml playbooks #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Apr 24, 2025

Refactoring to resolve a number of problems and inconsistencies between the site.yml and fatimage.yml playbooks. The major ones are:

  • iam.yml and slurm.yml playbooks are now run directly from fatimage.yml to make making changes to these less error-prone.
  • compute-init export task moved to a new final.yml playbook so it will run after any role which generates configuration which it might require. install.yml task for this role also been moved here for consistency - note this changes commands used for development.
  • gateway role which installs ansible-init playbook moved adjacent to ansible-init install
  • Ordering in site.yml and fatimage.yml is now consistent in that repos are disabled after any post-hook in both cases.
  • Unrunnable build VM cleanup code removed from site.yml.
  • Correctly define dependency of roles injecting ansible-init playbooks (compute_init, gateway) in groups hierarchy.

See https://wiki.stackhpc.com/doc/slurm-top-level-playbooks-HW9BlHDMpm for more detail

@sjpb
Copy link
Collaborator Author

sjpb commented Apr 25, 2025

@sjpb sjpb marked this pull request as ready for review April 25, 2025 12:42
@sjpb sjpb requested a review from a team as a code owner April 25, 2025 12:42
@sjpb
Copy link
Collaborator Author

sjpb commented Apr 25, 2025

Interactive testing @ 3120e49:

✔️ ondemand shell
✔️ ondemand remote desktop
✔️ ondemand files:
✔️ ondemand jupyter
✔️ ondemand monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant