Skip to content

[WIP] Create login subgroups in Ansible inventory #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Create login subgroups in Ansible inventory #727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions environments/skeleton/{{cookiecutter.environment}}/tofu/inventory.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ login:
${cluster_name}_${group_name}:
%{ endfor ~}

%{ for group_name in keys(login_groups) ~}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not make this consistent with way this is done for compute, and hoist the group defn inside the loop from line 19?

Or else make compute consistent with this, I don't care, but I think them being different is mentally hard to work out if they are doing something different. I don't think they are...

${group_name}:
children:
${cluster_name}_${group_name}
%{ endfor ~}

# --- compute nodes ---
%{ for group_name in keys(compute_groups) ~}
${cluster_name}_${group_name}:
Expand Down
Loading