Skip to content

Add support for topology-aware scheduling #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 24, 2025
Merged

Conversation

wtripp180901
Copy link
Contributor

@wtripp180901 wtripp180901 commented Jul 14, 2025

Enables Slurm's topology aware scheduling plugin for virtualised clusters. A topology tree is automatically created with four levels as follows (from the bottom up):

  • Compute VMs (leafs)
  • Hypervisors (switches)
  • Availability zones - used to model server racks (switches)
  • Top-level inter-rack switch

Note that the OpenTofu node group parameter availability_zone can now also be used for VMs, not just node groups with match_ironic_node set.

@wtripp180901 wtripp180901 requested a review from a team as a code owner July 14, 2025 09:26
@sjpb sjpb changed the title Add topology aware scheduling support Add support for topology-aware scheduling Jul 22, 2025
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty nice, a few comments to get it over the line please.

@sjpb sjpb self-requested a review July 22, 2025 10:38
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also - can you include this role in the support tables in both:

  • ansible/roles/compute_init/README.md
  • docs/experimental/isolated-clusters.md

please

@wtripp180901
Copy link
Contributor Author

^ added suggestion manually so I didn't have to cancel the CI again!

@sjpb sjpb self-requested a review July 24, 2025 10:05
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjpb sjpb merged commit b62a4c5 into main Jul 24, 2025
2 checks passed
@sjpb sjpb deleted the feat/topology-aware-scheduling branch July 24, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants