-
Notifications
You must be signed in to change notification settings - Fork 34
Add support for topology-aware scheduling #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty nice, a few comments to get it over the line please.
environments/skeleton/{{cookiecutter.environment}}/tofu/variables.tf
Outdated
Show resolved
Hide resolved
environments/skeleton/{{cookiecutter.environment}}/tofu/node_group/variables.tf
Outdated
Show resolved
Hide resolved
environments/skeleton/{{cookiecutter.environment}}/tofu/variables.tf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - can you include this role in the support tables in both:
- ansible/roles/compute_init/README.md
- docs/experimental/isolated-clusters.md
please
^ added suggestion manually so I didn't have to cancel the CI again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Enables Slurm's topology aware scheduling plugin for virtualised clusters. A topology tree is automatically created with four levels as follows (from the bottom up):
Note that the OpenTofu node group parameter
availability_zone
can now also be used for VMs, not just node groups withmatch_ironic_node
set.