Forward port from stackhpc/2024.1 to stackhpc/master #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to add extra network interface to cluster nodes, e.g. storage network. Story: 2002448 Task: 21983 Co-Authored-By: Bharat Kunwar <[email protected]> Change-Id: I10a6a4d72e9ec635f2c73d9fe64a8d136228f532 (cherry picked from commit bea8c72) (cherry picked from commit 8260f11) (cherry picked from commit d6c0a2d) (cherry picked from commit 6227555) (cherry picked from commit 3667d28) (cherry picked from commit 8562dde)
* Prometheus-server now runs only on master nodes. * Update prometheus-operator helm chart and tag. * Update prometheus-adapter version. * Deprecation notice for prometheus_monitoring component. task: 41569 story: 2006765 Signed-off-by: Diogo Guerra <[email protected]> Change-Id: I05e8c2be4e4c8e66a166b485ec7851875dca8b1c (cherry picked from commit 0934160) (cherry picked from commit 9a47696) (cherry picked from commit 3041908) (cherry picked from commit 5f786f0) (cherry picked from commit 4abaf43) (cherry picked from commit 7796430)
* Prometheus-server now runs only on master nodes. * Update prometheus-operator helm chart and tag. * Update prometheus-adapter version. * Deprecation notice for prometheus_monitoring component. Since v1.20 (changes are gradually introduced in next versions) k8s components are exposing (by default) metrics on 127.0.0.1 and are changing expose port. * Fix metrics address and ports post 1.20 * Extended memory limits to 64M * Changed expose addr to 127.0.0.1 * Changed expose ports task: 41569 story: 2006765 Signed-off-by: Diogo Guerra <[email protected]> Co-authored-by: Grzegorz Bialas <[email protected]> Change-Id: I05e8c2be4e4c8e66a166b485ec7851875dca8b1c (cherry picked from commit c92f605) (cherry picked from commit 32b22e5) (cherry picked from commit 5b56182) (cherry picked from commit 25e3bdc) (cherry picked from commit d0e1aa2) (cherry picked from commit 903f7f6)
In FCOS36 and later coredns started failing with loops. /etc/resolv.conf will not work with coredns (see [1]). Tested on FC35/36/37. [1]: https://github.com/coredns/coredns/blob/master/plugin/loop/README.md#troubleshooting Change-Id: I3a0700046bade7bd0b3a1b319f66b8f675f0c8fb (cherry picked from commit 037a71aaf8664a7f6a8926dceb294592d73da591) (cherry picked from commit bf99035) (cherry picked from commit 0f3ff1a) (cherry picked from commit fceb8d4) (cherry picked from commit a0b3952)
Appending to ca.crt in make-cert-client.sh (introduced in #724203) causes multiple identical ca certs being added into /etc/kubernetes/certs/ca.crt which prevents kube-controller-manager from starting with following error: 'expected 1 certificate, found X' Task: 45392 Story: 2010042 Change-Id: I5ca9cb8c7afb1ce9cb1a337a9fe2faf3fab3ba61 (cherry picked from commit 2c2dfeb) (cherry picked from commit 1994919)
(cherry picked from commit 15aee8b)
|
@darmach are you able to review this for us? |
darmach
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Looks fine to me, it would be good to test it before merging - or we should be aware to test it on dev/test env before actually deploying it as agreed @seunghun1ee
|
Had a discussion with @darmach again and we decided to merge this first then test/dev environment before actually deploying to production system. |
bbezak
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.