Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INFRA-388 Converting smartmon into python and adding mock tests #1327
base: stackhpc/2024.1
Are you sure you want to change the base?
INFRA-388 Converting smartmon into python and adding mock tests #1327
Changes from all commits
c037c4f
1b0cf9c
c5a8041
f68aea9
f4d60d7
0c74681
ed8e2bf
3a8d901
e0bae71
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you switch to the Prometheus library here? It is a slight change that it will write directly to a file for scraping. The advantage is that it handles all the metric formatting. A rough example:
https://prometheus.github.io/client_python/exporting/textfile/
Unchanged files with check annotations Beta
Check warning on line 1 in etc/kayobe/ansible/ubuntu-upgrade.yml
syntax-check[missing-file]
Check warning on line 1 in etc/kayobe/ansible/ubuntu-upgrade.yml
syntax-check[missing-file]
Check warning on line 32 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 33 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 40 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 41 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 49 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 50 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 61 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 62 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 72 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 73 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 91 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 92 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 100 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 101 in etc/kayobe/ansible/vault-deploy-barbican.yml
fqcn[action-core]
Check warning on line 45 in etc/kayobe/ansible/vault-generate-backend-tls.yml
fqcn[action-core]
Check warning on line 46 in etc/kayobe/ansible/vault-generate-backend-tls.yml
fqcn[action-core]
Check warning on line 14 in etc/kayobe/ansible/vault-generate-internal-tls.yml
fqcn[action-core]
Check warning on line 15 in etc/kayobe/ansible/vault-generate-internal-tls.yml
fqcn[action-core]